Normalize OpenSearch REST common javaagent package#18732
Merged
trask merged 1 commit intoMay 14, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the package of OpenSearch REST common javaagent classes from io.opentelemetry.javaagent.instrumentation.opensearch.rest to io.opentelemetry.javaagent.instrumentation.opensearch.rest.common, aligning the package name with the module name. Updates all dependent imports in the opensearch-rest-1.0 and opensearch-rest-3.0 modules.
Changes:
- Move 5 common classes and 1 abstract test under the new
.commonsubpackage. - Update imports in 1.0 and 3.0 instrumentation/test files to reference the new package.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| opensearch-rest-common/.../AbstractOpenSearchRestTest.java | Package renamed to .common. |
| opensearch-rest-common/.../RestResponseListener.java | Package renamed to .common. |
| opensearch-rest-common/.../OpenSearchRestResponse.java | Package renamed to .common. |
| opensearch-rest-common/.../OpenSearchRestRequest.java | Package renamed to .common. |
| opensearch-rest-common/.../OpenSearchRestInstrumenterFactory.java | Package renamed to .common. |
| opensearch-rest-common/.../OpenSearchRestAttributesGetter.java | Package renamed to .common. |
| opensearch-rest-3.0/.../OpenSearchRest3Test.java | Updated import to new package. |
| opensearch-rest-3.0/.../RestClientInstrumentation.java | Updated imports to new package. |
| opensearch-rest-3.0/.../OpenSearchRestSingletons.java | Updated imports to new package. |
| opensearch-rest-1.0/.../OpenSearchRestTest.java | Updated import to new package. |
| opensearch-rest-1.0/.../RestClientInstrumentation.java | Updated imports to new package. |
| opensearch-rest-1.0/.../OpenSearchRestSingletons.java | Updated imports to new package. |
steverao
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of