Normalize internal and resource javaagent packages#18746
Merged
trask merged 1 commit intoMay 18, 2026
Merged
Conversation
5953184 to
c25e8f7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns javaagent “resource” and “internal” instrumentation packages with the normalized io.opentelemetry.javaagent.instrumentation.* namespace (as part of the broader package/module alignment work referenced in #18428), ensuring these javaagent classes no longer live under the library-instrumentation io.opentelemetry.instrumentation.* namespace.
Changes:
- Renamed Spring Boot resource detector/provider package to
io.opentelemetry.javaagent.instrumentation.spring.boot.resources. - Renamed internal application logger instrumentation package to
io.opentelemetry.javaagent.instrumentation.internal.application.logger. - Updated affected unit/integration test packages to match the new production package names.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| instrumentation/spring/spring-boot-resources/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringBootServiceVersionDetectorTest.java | Update test package to normalized javaagent Spring Boot resources namespace. |
| instrumentation/spring/spring-boot-resources/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringBootServiceNameDetectorTest.java | Update test package to normalized javaagent Spring Boot resources namespace. |
| instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SystemHelper.java | Move helper into normalized javaagent Spring Boot resources namespace. |
| instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringResourceComponentProvider.java | Move component provider into normalized javaagent Spring Boot resources namespace. |
| instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringBootServiceVersionDetector.java | Move detector into normalized javaagent Spring Boot resources namespace. |
| instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringBootServiceNameDetector.java | Move detector into normalized javaagent Spring Boot resources namespace. |
| instrumentation/spring/spring-boot-resources/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/TestBootInfClassesResource.java | Update unit test package to normalized javaagent Spring Boot resources namespace. |
| instrumentation/internal/internal-application-logger/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/TestSpringApp.java | Update test app package to normalized internal application logger namespace. |
| instrumentation/internal/internal-application-logger/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/TestApp.java | Update test app package to normalized internal application logger namespace. |
| instrumentation/internal/internal-application-logger/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/ApplicationLoggerInstrumentationTest.java | Update test package to normalized internal application logger namespace. |
| instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/SpringApplicationInstrumentation.java | Move instrumentation into normalized internal application logger namespace. |
| instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/Slf4jApplicationLoggerBridge.java | Move bridge into normalized internal application logger namespace. |
| instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/LoggingApplicationListenerInstrumentation.java | Move instrumentation into normalized internal application logger namespace. |
| instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/LoggerFactoryInstrumentation.java | Move instrumentation into normalized internal application logger namespace. |
| instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/ApplicationLoggingInstrumentationModule.java | Move module into normalized internal application logger namespace. |
| instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/ApplicationLoggingIgnoredTypesConfigurer.java | Move ignored-types configurer into normalized internal application logger namespace. |
steverao
approved these changes
May 18, 2026
laurit
reviewed
May 18, 2026
| */ | ||
|
|
||
| package io.opentelemetry.instrumentation.spring.resources; | ||
| package io.opentelemetry.javaagent.instrumentation.spring.boot.resources; |
Contributor
There was a problem hiding this comment.
resource provider class names are sort of part of public api, might need to call this our as a breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of