Skip to content

Normalize internal and resource javaagent packages#18746

Merged
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-internal-resource-packages
May 18, 2026
Merged

Normalize internal and resource javaagent packages#18746
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-internal-resource-packages

Conversation

@trask

@trask trask commented May 14, 2026

Copy link
Copy Markdown
Member

@trask trask force-pushed the package-name-cleanup-internal-resource-packages branch from 5953184 to c25e8f7 Compare May 17, 2026 23:57
@trask trask marked this pull request as ready for review May 18, 2026 02:54
@trask trask requested a review from a team as a code owner May 18, 2026 02:54
Copilot AI review requested due to automatic review settings May 18, 2026 02:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns javaagent “resource” and “internal” instrumentation packages with the normalized io.opentelemetry.javaagent.instrumentation.* namespace (as part of the broader package/module alignment work referenced in #18428), ensuring these javaagent classes no longer live under the library-instrumentation io.opentelemetry.instrumentation.* namespace.

Changes:

  • Renamed Spring Boot resource detector/provider package to io.opentelemetry.javaagent.instrumentation.spring.boot.resources.
  • Renamed internal application logger instrumentation package to io.opentelemetry.javaagent.instrumentation.internal.application.logger.
  • Updated affected unit/integration test packages to match the new production package names.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
instrumentation/spring/spring-boot-resources/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringBootServiceVersionDetectorTest.java Update test package to normalized javaagent Spring Boot resources namespace.
instrumentation/spring/spring-boot-resources/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringBootServiceNameDetectorTest.java Update test package to normalized javaagent Spring Boot resources namespace.
instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SystemHelper.java Move helper into normalized javaagent Spring Boot resources namespace.
instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringResourceComponentProvider.java Move component provider into normalized javaagent Spring Boot resources namespace.
instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringBootServiceVersionDetector.java Move detector into normalized javaagent Spring Boot resources namespace.
instrumentation/spring/spring-boot-resources/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/SpringBootServiceNameDetector.java Move detector into normalized javaagent Spring Boot resources namespace.
instrumentation/spring/spring-boot-resources/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/boot/resources/TestBootInfClassesResource.java Update unit test package to normalized javaagent Spring Boot resources namespace.
instrumentation/internal/internal-application-logger/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/TestSpringApp.java Update test app package to normalized internal application logger namespace.
instrumentation/internal/internal-application-logger/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/TestApp.java Update test app package to normalized internal application logger namespace.
instrumentation/internal/internal-application-logger/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/ApplicationLoggerInstrumentationTest.java Update test package to normalized internal application logger namespace.
instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/SpringApplicationInstrumentation.java Move instrumentation into normalized internal application logger namespace.
instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/Slf4jApplicationLoggerBridge.java Move bridge into normalized internal application logger namespace.
instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/LoggingApplicationListenerInstrumentation.java Move instrumentation into normalized internal application logger namespace.
instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/LoggerFactoryInstrumentation.java Move instrumentation into normalized internal application logger namespace.
instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/ApplicationLoggingInstrumentationModule.java Move module into normalized internal application logger namespace.
instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/application/logger/ApplicationLoggingIgnoredTypesConfigurer.java Move ignored-types configurer into normalized internal application logger namespace.

@trask trask merged commit 4c6155a into open-telemetry:main May 18, 2026
99 checks passed
@trask trask deleted the package-name-cleanup-internal-resource-packages branch May 18, 2026 14:11
*/

package io.opentelemetry.instrumentation.spring.resources;
package io.opentelemetry.javaagent.instrumentation.spring.boot.resources;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource provider class names are sort of part of public api, might need to call this our as a breaking change

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, sent #18785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants