Skip to content

Normalize JAX-RS 2.0 annotation and common javaagent packages#18748

Merged
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-jaxrs-2-common-annotations
May 16, 2026
Merged

Normalize JAX-RS 2.0 annotation and common javaagent packages#18748
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-jaxrs-2-common-annotations

Conversation

@trask

@trask trask commented May 14, 2026

Copy link
Copy Markdown
Member

@trask trask marked this pull request as ready for review May 15, 2026 18:49
@trask trask requested a review from a team as a code owner May 15, 2026 18:49
Copilot AI review requested due to automatic review settings May 15, 2026 18:49
@trask trask marked this pull request as draft May 15, 2026 18:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns JAX-RS 2.0 javaagent package structure by separating shared “common” helpers and JAX-RS-annotations instrumentation into clearer, normalized packages (part of the broader package/module alignment in #18428).

Changes:

  • Moved shared JAX-RS 2.0 helper types into io.opentelemetry.javaagent.instrumentation.jaxrs.v2_0.common and updated downstream imports.
  • Moved JAX-RS 2.0 annotations instrumentation (and its tests) into io.opentelemetry.javaagent.instrumentation.jaxrs.v2_0.annotations.
  • Updated instrumentation classes across RESTEasy/Jersey/CXF and annotations modules to reference the new package locations.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-3.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/resteasy/v3_1/Resteasy31RequestContextInstrumentation.java Updates imports to use the new v2_0.common shared helpers.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/resteasy/v3_0/Resteasy30RequestContextInstrumentation.java Updates imports to use the new v2_0.common shared helpers.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-jersey-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/jersey/v2_0/JerseyRequestContextInstrumentation.java Updates imports to use the new v2_0.common shared helpers.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-cxf-3.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/cxf/v3_2/CxfRequestContextInstrumentation.java Updates imports to use the new v2_0.common shared helpers.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/common/Jaxrs2RequestContextHelper.java Changes package declaration to v2_0.common.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/common/Jaxrs2HandlerData.java Changes package declaration to v2_0.common.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/common/AbstractRequestContextInstrumentation.java Changes package declaration to v2_0.common.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/annotations/JaxRs2AnnotationsInstrumentationTest.java Moves test package to v2_0.annotations and updates nested-type import.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/annotations/JavaInterfaces.java Moves test helper package to v2_0.annotations.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/annotations/JaxrsAsyncResponseInstrumentation.java Moves instrumentation package to v2_0.annotations and updates singleton static imports.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/annotations/JaxrsAnnotationsSingletons.java Moves singleton holder package to v2_0.annotations.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/annotations/JaxrsAnnotationsInstrumentationModule.java Moves module class package to v2_0.annotations.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/annotations/JaxrsAnnotationsInstrumentation.java Moves instrumentation package to v2_0.annotations and imports Jaxrs2HandlerData from v2_0.common.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/annotations/DefaultRequestContextInstrumentation.java Moves default request-context instrumentation into v2_0.annotations and imports common base/data types.
instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/annotations/ContainerRequestFilterInstrumentation.java Moves filter instrumentation into v2_0.annotations.

@trask trask force-pushed the package-name-cleanup-jaxrs-2-common-annotations branch 2 times, most recently from 3346168 to 101e1b6 Compare May 15, 2026 19:35
@trask trask marked this pull request as ready for review May 15, 2026 19:37
@trask trask requested a review from Copilot May 15, 2026 19:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

@trask trask merged commit d79e25c into open-telemetry:main May 16, 2026
370 of 374 checks passed
@trask trask deleted the package-name-cleanup-jaxrs-2-common-annotations branch May 16, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants