Gate Wicket resource span names on v3 preview#18775
Merged
trask merged 2 commits intoMay 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR gates the Wicket resource span renaming behavior (introduced in #18312) behind the otel.instrumentation.common.v3-preview flag to avoid a breaking change in default span names.
Changes:
- Gate
ResourceReferenceRequestHandler-based route/span renaming onSemconvStability.v3Preview(). - Update Wicket tests to assert the legacy vs v3-preview resource span name based on the flag.
- Add Gradle
testV3Previewtasks (and wire them intocheck) to run the Wicket test suites with v3-preview enabled.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| instrumentation/wicket-8.0/wicket8-testing/build.gradle.kts | Adds a testV3Preview Gradle test task that enables the v3-preview flag and runs under check. |
| instrumentation/wicket-8.0/wicket10-testing/build.gradle.kts | Same as above for the Wicket 10 test matrix. |
| instrumentation/wicket-8.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/wicket/v8_0/RequestHandlerExecutorInstrumentation.java | Gates resource route/span renaming logic on the v3-preview flag. |
| instrumentation/wicket-8.0/common-testing/src/main/java/io/opentelemetry/javaagent/instrumentation/wicket/v8_0/AbstractWicketTest.java | Adjusts resource span name assertion to match legacy vs v3-preview behavior. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
laurit
approved these changes
May 18, 2026
laurit
left a comment
laurit
left a comment
Contributor
There was a problem hiding this comment.
I think that placing this behind the v3 preview flag is probably an overkill, we could just document it in the release notes.
SylvainJuge
pushed a commit
to SylvainJuge/opentelemetry-java-instrumentation
that referenced
this pull request
May 20, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realized #18312 is breaking change, so hiding it behind v3 preview flag cc @asvanberg