Rename servlet common snippet package#18777
Merged
trask merged 1 commit intoMay 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pure package rename: moves the two snippet helper classes from io.opentelemetry.javaagent.instrumentation.servlet.snippet to io.opentelemetry.javaagent.instrumentation.servlet.common.snippet to align with the directory layout under servlet-common, and updates all importers in servlet-3.0 and servlet-5.0.
Changes:
- Update package declaration on
SnippetInjectingPrintWriterandOutputStreamSnippetInjectionHelper. - Update imports in servlet-3.0/5.0 wrappers, singletons, and unit tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| servlet-common/.../snippet/SnippetInjectingPrintWriter.java | Package declaration moved under .common.snippet. |
| servlet-common/.../snippet/OutputStreamSnippetInjectionHelper.java | Package declaration moved under .common.snippet. |
| servlet-5.0/.../Servlet5SnippetInjectingResponseWrapper.java | Import updated to new package. |
| servlet-5.0/.../Servlet5Singletons.java | Import updated to new package. |
| servlet-5.0 javaagent-unit-tests/.../SnippetServletOutputStreamTest.java | Import updated to new package. |
| servlet-3.0/.../Servlet3SnippetInjectingResponseWrapper.java | Import updated to new package. |
| servlet-3.0/.../Servlet3Singletons.java | Import updated to new package. |
| servlet-3.0 javaagent-unit-tests/.../SnippetServletOutputStreamTest.java | Import updated to new package. |
steverao
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of