Skip to content

Rename servlet common snippet package#18777

Merged
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-servlet-common-snippet
May 18, 2026
Merged

Rename servlet common snippet package#18777
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-servlet-common-snippet

Conversation

@trask

@trask trask commented May 18, 2026

Copy link
Copy Markdown
Member

@trask trask marked this pull request as ready for review May 18, 2026 04:16
@trask trask requested a review from a team as a code owner May 18, 2026 04:16
Copilot AI review requested due to automatic review settings May 18, 2026 04:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pure package rename: moves the two snippet helper classes from io.opentelemetry.javaagent.instrumentation.servlet.snippet to io.opentelemetry.javaagent.instrumentation.servlet.common.snippet to align with the directory layout under servlet-common, and updates all importers in servlet-3.0 and servlet-5.0.

Changes:

  • Update package declaration on SnippetInjectingPrintWriter and OutputStreamSnippetInjectionHelper.
  • Update imports in servlet-3.0/5.0 wrappers, singletons, and unit tests.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
servlet-common/.../snippet/SnippetInjectingPrintWriter.java Package declaration moved under .common.snippet.
servlet-common/.../snippet/OutputStreamSnippetInjectionHelper.java Package declaration moved under .common.snippet.
servlet-5.0/.../Servlet5SnippetInjectingResponseWrapper.java Import updated to new package.
servlet-5.0/.../Servlet5Singletons.java Import updated to new package.
servlet-5.0 javaagent-unit-tests/.../SnippetServletOutputStreamTest.java Import updated to new package.
servlet-3.0/.../Servlet3SnippetInjectingResponseWrapper.java Import updated to new package.
servlet-3.0/.../Servlet3Singletons.java Import updated to new package.
servlet-3.0 javaagent-unit-tests/.../SnippetServletOutputStreamTest.java Import updated to new package.

@trask trask merged commit d52a5ff into open-telemetry:main May 18, 2026
99 checks passed
@trask trask deleted the package-name-cleanup-servlet-common-snippet branch May 18, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants