Rename Jetty and Tomcat common modules#18786
Merged
trask merged 1 commit intoMay 19, 2026
Merged
Conversation
trask
force-pushed
the
package-name-cleanup-jetty-tomcat-common
branch
from
18d200e to
2603bc5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the tomcat-common and jetty-common javaagent modules to tomcat-common-7.0 and jetty-common-8.0 respectively, aligning module names with the minimum supported version convention, and adds matching v7_0/v8_0 package suffixes. Part of #18428.
Changes:
- Renamed Gradle modules and updated
settings.gradle.kts,.fossa.yml, READMEs, and all dependent build files. - Moved common Tomcat sources into the
...tomcat.common.v7_0package and common Jetty sources into the...jetty.common.v8_0package. - Updated all import references in dependent Tomcat 7.0/10.0 and Jetty 8.0/11.0 modules.
Reviewed changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Replaces old module paths with renamed ones. |
| .fossa.yml | Updates Gradle target paths for the renamed modules. |
| instrumentation/tomcat/README.md | Reflects the new tomcat-common-7.0 module name. |
| instrumentation/tomcat/tomcat-common-7.0/javaagent/build.gradle.kts | New build script for the renamed module. |
| instrumentation/tomcat/tomcat-common-7.0/.../v7_0/*.java | Package declarations updated to ...tomcat.common.v7_0. |
| instrumentation/tomcat/tomcat-7.0/javaagent/** | Updated imports and dependency to renamed common module. |
| instrumentation/tomcat/tomcat-10.0/javaagent/** | Updated imports and dependency to renamed common module. |
| instrumentation/jetty/README.md | Reflects the new jetty-common-8.0 module name. |
| instrumentation/jetty/jetty-common-8.0/javaagent/build.gradle.kts | New build script for the renamed module. |
| instrumentation/jetty/jetty-common-8.0/.../v8_0/*.java | Package declarations updated to ...jetty.common.v8_0. |
| instrumentation/jetty/jetty-8.0/javaagent/** | Updated imports and dependency to renamed common module. |
| instrumentation/jetty/jetty-11.0/javaagent/** | Updated imports and dependency to renamed common module. |
| instrumentation/jfinal-3.2/javaagent/build.gradle.kts | Updates testInstrumentation dependency to renamed jetty-common-8.0. |
laurit
approved these changes
May 19, 2026
SylvainJuge
pushed a commit
to SylvainJuge/opentelemetry-java-instrumentation
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of