Rename OpenSearch REST common module#18787
Merged
trask merged 1 commit intoMay 19, 2026
Merged
Conversation
fe3dfe4 to
820a40e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the shared OpenSearch REST “common” instrumentation module to a versioned module (opensearch-rest-common-1.0) and aligns the shared helper package names accordingly, as part of broader module/package name alignment work.
Changes:
- Renamed the Gradle projects from
opensearch-rest-commontoopensearch-rest-common-1.0and updated all project references. - Moved shared javaagent helper classes into a versioned package (
...rest.common.v1_0) and updated imports in the REST 1.0/3.0 instrumentations. - Introduced a dedicated
testingsubproject for shared OpenSearch REST test utilities.
Reviewed changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
settings.gradle.kts |
Switches includes to the new opensearch-rest-common-1.0 project paths. |
instrumentation/opensearch/opensearch-rest-common-1.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/AbstractOpenSearchRestTest.java |
Adds shared REST client trace/metric assertions used by REST instrumentation tests. |
instrumentation/opensearch/opensearch-rest-common-1.0/testing/build.gradle.kts |
Defines dependencies for the shared OpenSearch REST testing utilities. |
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/v1_0/RestResponseListener.java |
Updates package to the new versioned namespace. |
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/v1_0/OpenSearchRestResponse.java |
Updates package to the new versioned namespace. |
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/v1_0/OpenSearchRestRequest.java |
Updates package to the new versioned namespace. |
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/v1_0/OpenSearchRestInstrumenterFactory.java |
Updates package to the new versioned namespace. |
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/v1_0/OpenSearchRestAttributesGetter.java |
Updates package to the new versioned namespace. |
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/build.gradle.kts |
Adds the javaagent subproject build definition for the renamed common module. |
instrumentation/opensearch/opensearch-rest-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/v3_0/RestClientInstrumentation.java |
Updates imports to reference the versioned common helper package. |
instrumentation/opensearch/opensearch-rest-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/v3_0/OpenSearchRestSingletons.java |
Updates imports to reference the versioned common helper package. |
instrumentation/opensearch/opensearch-rest-3.0/javaagent/build.gradle.kts |
Updates project dependencies to the renamed common javaagent/testing projects. |
instrumentation/opensearch/opensearch-rest-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/v1_0/RestClientInstrumentation.java |
Updates imports to reference the versioned common helper package. |
instrumentation/opensearch/opensearch-rest-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/v1_0/OpenSearchRestSingletons.java |
Updates imports to reference the versioned common helper package. |
instrumentation/opensearch/opensearch-rest-1.0/javaagent/build.gradle.kts |
Updates project dependencies to the renamed common javaagent/testing projects. |
instrumentation/opensearch/opensearch-java-3.0/javaagent/build.gradle.kts |
Updates test dependency to the renamed common testing project. |
.fossa.yml |
Updates the Gradle target to reflect the renamed common module. |
laurit
approved these changes
May 19, 2026
SylvainJuge
pushed a commit
to SylvainJuge/opentelemetry-java-instrumentation
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of