Skip to content

Rename OpenSearch REST common module#18787

Merged
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-opensearch-rest-common
May 19, 2026
Merged

Rename OpenSearch REST common module#18787
trask merged 1 commit into
open-telemetry:mainfrom
trask:package-name-cleanup-opensearch-rest-common

Conversation

@trask

@trask trask commented May 18, 2026

Copy link
Copy Markdown
Member

@trask trask force-pushed the package-name-cleanup-opensearch-rest-common branch from fe3dfe4 to 820a40e Compare May 18, 2026 17:53
@trask trask marked this pull request as ready for review May 18, 2026 17:58
@trask trask requested a review from a team as a code owner May 18, 2026 17:58
Copilot AI review requested due to automatic review settings May 18, 2026 17:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the shared OpenSearch REST “common” instrumentation module to a versioned module (opensearch-rest-common-1.0) and aligns the shared helper package names accordingly, as part of broader module/package name alignment work.

Changes:

  • Renamed the Gradle projects from opensearch-rest-common to opensearch-rest-common-1.0 and updated all project references.
  • Moved shared javaagent helper classes into a versioned package (...rest.common.v1_0) and updated imports in the REST 1.0/3.0 instrumentations.
  • Introduced a dedicated testing subproject for shared OpenSearch REST test utilities.

Reviewed changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
settings.gradle.kts Switches includes to the new opensearch-rest-common-1.0 project paths.
instrumentation/opensearch/opensearch-rest-common-1.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/AbstractOpenSearchRestTest.java Adds shared REST client trace/metric assertions used by REST instrumentation tests.
instrumentation/opensearch/opensearch-rest-common-1.0/testing/build.gradle.kts Defines dependencies for the shared OpenSearch REST testing utilities.
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/v1_0/RestResponseListener.java Updates package to the new versioned namespace.
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/v1_0/OpenSearchRestResponse.java Updates package to the new versioned namespace.
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/v1_0/OpenSearchRestRequest.java Updates package to the new versioned namespace.
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/v1_0/OpenSearchRestInstrumenterFactory.java Updates package to the new versioned namespace.
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/common/v1_0/OpenSearchRestAttributesGetter.java Updates package to the new versioned namespace.
instrumentation/opensearch/opensearch-rest-common-1.0/javaagent/build.gradle.kts Adds the javaagent subproject build definition for the renamed common module.
instrumentation/opensearch/opensearch-rest-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/v3_0/RestClientInstrumentation.java Updates imports to reference the versioned common helper package.
instrumentation/opensearch/opensearch-rest-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/v3_0/OpenSearchRestSingletons.java Updates imports to reference the versioned common helper package.
instrumentation/opensearch/opensearch-rest-3.0/javaagent/build.gradle.kts Updates project dependencies to the renamed common javaagent/testing projects.
instrumentation/opensearch/opensearch-rest-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/v1_0/RestClientInstrumentation.java Updates imports to reference the versioned common helper package.
instrumentation/opensearch/opensearch-rest-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/v1_0/OpenSearchRestSingletons.java Updates imports to reference the versioned common helper package.
instrumentation/opensearch/opensearch-rest-1.0/javaagent/build.gradle.kts Updates project dependencies to the renamed common javaagent/testing projects.
instrumentation/opensearch/opensearch-java-3.0/javaagent/build.gradle.kts Updates test dependency to the renamed common testing project.
.fossa.yml Updates the Gradle target to reflect the renamed common module.

@trask trask merged commit 7f3299b into open-telemetry:main May 19, 2026
101 checks passed
@trask trask deleted the package-name-cleanup-opensearch-rest-common branch May 19, 2026 14:25
SylvainJuge pushed a commit to SylvainJuge/opentelemetry-java-instrumentation that referenced this pull request May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants