Fallback to old muzzle resolution when pinned versions file is missing#18834
Merged
trask merged 5 commits intoMay 28, 2026
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Gradle muzzle-check plugin to keep using the repo’s pinned latest-dep versions file when present, but to gracefully fall back to resolving full version ranges from configured repositories when that pinned file is absent (supporting external users who apply the plugin outside this repo).
Changes:
- Make
.github/config/latest-dep-versions.jsonoptional: log an informational message and fall back instead of failing fast when missing. - Propagate optional “upper bound” handling by making
resolveUpperBound()return nullable and updating version filtering to treat a missing upper bound as “no cap”. - Update documentation comments to reflect the new fallback behavior.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
laurit
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
.github/config/latest-dep-versions.jsonis present, keep using it to cap open-ended muzzle ranges for reproducible in-repo builds.When that file is absent, fall back to the old behavior and resolve the full version range from the configured repositories instead of failing immediately.
This keeps the pinned-version behavior for this repository while restoring compatibility for external users such as distros and extension authors that apply the muzzle check plugin outside this repo.