Rename Payara module to include base version#18835
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the Payara instrumentation module naming with the repository’s versioned-module convention by renaming it to include the base version (payara-5.2020), and updating related identifiers and documentation references accordingly.
Changes:
- Renamed the Gradle project path from
:instrumentation:payara:javaagentto:instrumentation:payara-5.2020:javaagentand updated FOSSA target configuration. - Updated the Payara javaagent package/module naming to
...payara.v5_2020and added the versioned instrumentation name toInstrumentationModule. - Adjusted documentation/metadata to reflect the new module path and identifier; updated embedded Payara dependency version to
5.2020.2.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Updates Gradle includes to the versioned Payara module path. |
| instrumentation/payara-5.2020/metadata.yaml | Adds module metadata for docs generation under the new module name/path. |
| instrumentation/payara-5.2020/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/payara/v5_2020/StandardWrapperInstrumentation.java | Moves the instrumentation class into the versioned Payara package. |
| instrumentation/payara-5.2020/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/payara/v5_2020/PayaraInstrumentationModule.java | Updates package and registers both stable and versioned instrumentation names. |
| instrumentation/payara-5.2020/javaagent/build.gradle.kts | Aligns the embedded Payara dependency to the 5.2020.x line. |
| docs/instrumentation-list.yaml | Renames the Payara entry, updates source_path and scope name to the versioned module. |
| .fossa.yml | Updates the Payara Gradle target to the new project path. |
jaydeluca
approved these changes
May 22, 2026
jaydeluca
left a comment
jaydeluca
left a comment
Member
There was a problem hiding this comment.
interesting versioning approach 🤮
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of