Add override for tomcat-jdbc scope name#18860
Open
jaydeluca wants to merge 1 commit into
Open
Conversation
jaydeluca
commented
May 27, 2026
| entry("io.opentelemetry.runtime-telemetry", singleton("test"))); | ||
| entry("io.opentelemetry.runtime-telemetry", singleton("test")), | ||
| // tomcat-jdbc was renamed to tomcat-jdbc-8.5 but the scope name was not changed | ||
| entry("io.opentelemetry.tomcat-jdbc-8.5", singleton("io.opentelemetry.tomcat-jdbc"))); |
Member
Author
There was a problem hiding this comment.
alternatively we could update the actual scope name, but I wasn't sure if we've been doing that as part of #18428
Contributor
There was a problem hiding this comment.
@trask should we put the update to the scope name behind v3 preview flag or can we do it right away?
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the instrumentation-docs telemetry parsing allow-list to account for the tomcat-jdbc → tomcat-jdbc-8.5 module rename where the emitted telemetry scope name remained io.opentelemetry.tomcat-jdbc. This prevents the docs telemetry validation from incorrectly excluding signals coming from the renamed module.
Changes:
- Add a scope allow-list override mapping
io.opentelemetry.tomcat-jdbc-8.5to permit telemetry emitted underio.opentelemetry.tomcat-jdbc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #18857 (comment)