Skip to content

Add override for tomcat-jdbc scope name #18860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaydeluca wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Add override for tomcat-jdbc scope name #18860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ion-docs/src/main/java/io/opentelemetry/instrumentation/docs/parsers/TelemetryParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ class TelemetryParser {
// servlet-5.0 tests use jetty-12.0 instrumentation
entry("io.opentelemetry.servlet-5.0", singleton("io.opentelemetry.jetty-12.0")),
// runtime-telemetry library tests use a meter named "test"
entry("io.opentelemetry.runtime-telemetry", singleton("test")));
entry("io.opentelemetry.runtime-telemetry", singleton("test")),
// tomcat-jdbc was renamed to tomcat-jdbc-8.5 but the scope name was not changed
entry("io.opentelemetry.tomcat-jdbc-8.5", singleton("io.opentelemetry.tomcat-jdbc")));
Copy link
Copy Markdown
Member Author

@jaydeluca jaydeluca May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively we could update the actual scope name, but I wasn't sure if we've been doing that as part of #18428

Copy link
Copy Markdown
Contributor

@laurit laurit May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask should we put the update to the scope name behind v3 preview flag or can we do it right away?

Copy link
Copy Markdown
Member

@trask trask May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, looks like I missed this when updating the module name, check out what I did in CxfSingletons.java

Copy link
Copy Markdown
Member

@trask trask May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll send PR, looks like I also missed for oshi

}

/**
Expand Down
Loading