Skip to content

Emit FaaS exceptions as logs under the opt-in preview#18892

Merged
laurit merged 5 commits into
open-telemetry:mainfrom
trask:trask/faas-exception-events
Jun 9, 2026
Merged

Emit FaaS exceptions as logs under the opt-in preview#18892
laurit merged 5 commits into
open-telemetry:mainfrom
trask:trask/faas-exception-events

Conversation

@trask

@trask trask commented Jun 3, 2026

Copy link
Copy Markdown
Member

Under otel.semconv.exception.signal.preview=logs (introduced in #16259), FaaS instrumentations now emit their exceptions as log records instead of span events.

Part of follow-up work after #16259.

@trask trask force-pushed the trask/faas-exception-events branch from cf030ad to 5d8e625 Compare June 3, 2026 18:39
@trask trask force-pushed the trask/faas-exception-events branch from 5d8e625 to 27e39b6 Compare June 3, 2026 20:07
@trask trask changed the title Add FaaS exception event extractor helper Add FaaS exception event extractor wiring Jun 3, 2026
@trask trask changed the title Add FaaS exception event extractor wiring Emit FaaS exceptions as logs under the opt-in preview Jun 3, 2026
@trask trask requested a review from Copilot June 3, 2026 22:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates AWS Lambda (FaaS) instrumentation to customize exception log emission under the otel.semconv.exception.signal.preview=logs opt-in, aligning Lambda exception logs with a FaaS-specific event name/severity.

Changes:

  • Add a small incubator helper (FaasExceptionEventExtractors) that configures the exception log event name/severity for FaaS invocations.
  • Wire the helper into AWS Lambda core and events-common instrumenter builders so the exception signal is configured consistently.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
instrumentation/aws-lambda/aws-lambda-events-common-2.2/library/src/main/java/io/opentelemetry/instrumentation/awslambdaevents/common/v2_2/internal/AwsLambdaEventsInstrumenterFactory.java Applies the FaaS exception log event extractor to the events-common Lambda instrumenter builder.
instrumentation/aws-lambda/aws-lambda-core-1.0/library/src/main/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/internal/AwsLambdaFunctionInstrumenterFactory.java Applies the FaaS exception log event extractor to the core Lambda instrumenter builder.
instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/faas/FaasExceptionEventExtractors.java Introduces a reusable helper to set the exception log event name (faas.invocation.exception) and severity (ERROR).

@trask trask force-pushed the trask/faas-exception-events branch from 27e39b6 to eae016b Compare June 3, 2026 22:51
@trask trask requested a review from Copilot June 4, 2026 23:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

@trask trask force-pushed the trask/faas-exception-events branch 2 times, most recently from 30752f4 to 9427f79 Compare June 5, 2026 00:13
@trask trask requested a review from Copilot June 5, 2026 00:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

@trask trask force-pushed the trask/faas-exception-events branch 3 times, most recently from a2d4a3f to 0cac209 Compare June 5, 2026 23:52
@trask trask requested a review from Copilot June 6, 2026 00:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.

@trask trask marked this pull request as ready for review June 6, 2026 00:53
@trask trask requested a review from a team as a code owner June 6, 2026 00:53
@trask trask force-pushed the trask/faas-exception-events branch from aec8d59 to ee3b121 Compare June 6, 2026 18:46
@trask trask requested a review from Copilot June 6, 2026 22:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

@laurit laurit merged commit efba62a into open-telemetry:main Jun 9, 2026
181 of 184 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants