Enable jvm.gc.cause attribute by default#18967
Open
somiljain2006 wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates runtime-telemetry configuration so GC cause capture is enabled by default, with documentation and tests reflecting the new default and deprecation behavior when disabling it.
Changes:
- Switched
capture-gc-causedefault fromfalsetotruein Spring Boot metadata and runtime-telemetry docs. - Updated runtime-telemetry internal config default to
trueand adjusted the deprecation warning to trigger when disabling. - Added unit tests to validate the new default and the ability to disable.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| instrumentation/spring/spring-boot-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json | Updates Spring Boot config metadata default for capture-gc-cause to true. |
| instrumentation/runtime-telemetry/library/src/main/java/io/opentelemetry/instrumentation/runtimetelemetry/internal/Internal.java | Changes config default to enabled and updates warning behavior/message when disabling. |
| instrumentation/runtime-telemetry/README.md | Documents the new default value for capture-gc-cause. |
| instrumentation/runtime-telemetry/library/src/test/java/io/opentelemetry/instrumentation/runtimetelemetry/RuntimeTelemetryTest.java | Adds tests validating default behavior and disabling behavior. |
trask
reviewed
Jun 11, 2026
trask
reviewed
Jun 11, 2026
trask
reviewed
Jun 11, 2026
Author
|
@trask I have done the required changes, can you review them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16063
Change runtime telemetry to default capture_gc_cause to true, while preserving the deprecated configuration option for
backward compatibility. Update the documentation and Spring configuration metadata, and add tests covering the new default behavior and explicit opt-out.