Skip to content

Support Redisson batch operations#18985

Merged
laurit merged 2 commits into
open-telemetry:mainfrom
trask:redisson-stable-batch-spans
Jun 15, 2026
Merged

Support Redisson batch operations#18985
laurit merged 2 commits into
open-telemetry:mainfrom
trask:redisson-stable-batch-spans

Conversation

@trask

@trask trask commented Jun 13, 2026

Copy link
Copy Markdown
Member

Summary

  • derive stable Redisson multi-command operation names as PIPELINE <command> or MULTI <command>

@trask trask changed the title Fix Redisson stable batch span names Support Redisson batch operations Jun 13, 2026
@trask trask requested a review from Copilot June 13, 2026 18:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Redisson instrumentation to emit stable database semantic convention operation names for multi-command (batch) requests, producing names like PIPELINE <command> and MULTI <command> and updating tests accordingly.

Changes:

  • Derive batch operation names for CommandsData requests in RedissonRequest when stable DB semconv is enabled.
  • Update Redisson sync client tests to expect PIPELINE SET / MULTI SET span names and db.operation.name attributes for batch operations.
  • Update Redisson async client tests to expect MULTI SET span names and db.operation.name attributes for atomic batch operations.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
instrumentation/redisson/redisson-common-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/common/v3_0/RedissonRequest.java Adds stable batch operation name derivation for pipeline/transaction batches.
instrumentation/redisson/redisson-common-3.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/AbstractRedissonClientTest.java Updates sync client batch tests to assert new stable span names and db.operation.name.
instrumentation/redisson/redisson-common-3.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/AbstractRedissonAsyncClientTest.java Updates async atomic batch test to assert new stable span name and db.operation.name.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@trask trask marked this pull request as ready for review June 14, 2026 01:30
@trask trask requested a review from a team as a code owner June 14, 2026 01:30
@laurit laurit merged commit 1fc2590 into open-telemetry:main Jun 15, 2026
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants