Support Redisson batch operations#18985
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Redisson instrumentation to emit stable database semantic convention operation names for multi-command (batch) requests, producing names like PIPELINE <command> and MULTI <command> and updating tests accordingly.
Changes:
- Derive batch operation names for
CommandsDatarequests inRedissonRequestwhen stable DB semconv is enabled. - Update Redisson sync client tests to expect
PIPELINE SET/MULTI SETspan names anddb.operation.nameattributes for batch operations. - Update Redisson async client tests to expect
MULTI SETspan names anddb.operation.nameattributes for atomic batch operations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| instrumentation/redisson/redisson-common-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/common/v3_0/RedissonRequest.java | Adds stable batch operation name derivation for pipeline/transaction batches. |
| instrumentation/redisson/redisson-common-3.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/AbstractRedissonClientTest.java | Updates sync client batch tests to assert new stable span names and db.operation.name. |
| instrumentation/redisson/redisson-common-3.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/redisson/AbstractRedissonAsyncClientTest.java | Updates async atomic batch test to assert new stable span name and db.operation.name. |
laurit
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PIPELINE <command>orMULTI <command>