Disable hbase tests on openj9#18998
Merged
Merged
Conversation
laurit
added
the
test openj9
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables the HBase client 2.0 javaagent tests when running on OpenJ9-based JVMs, to avoid known failures in that runtime and keep CI signal actionable.
Changes:
- Added JUnit 5
@DisabledIfSystemPropertygating to skipHbaseClient20Teston OpenJ9. - Added the same OpenJ9 gating for the shaded-client variant
HbaseShadedClient20Test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| instrumentation/hbase-client-2.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hbase/client/v2_0/HbaseClient20Test.java | Disables the standard HBase 2.0 client javaagent test on OpenJ9 JVMs. |
| instrumentation/hbase-client-2.0/javaagent/src/shadedClientTest/java/io/opentelemetry/javaagent/instrumentation/hbase/client/v2_0/HbaseShadedClient20Test.java | Disables the shaded HBase 2.0 client javaagent test on OpenJ9 JVMs. |
| import org.junit.jupiter.api.condition.DisabledIfSystemProperty; | ||
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
|
||
| @DisabledIfSystemProperty(named = "java.vm.name", matches = ".*OpenJ9.*") |
Contributor
Author
There was a problem hiding this comment.
It is fine since we only run these on openj9 and not the ibm vm. Note that the @DisabledIfSystemProperty in AbstractHttpClientTest doesn't really apply since that test is not run on ibm vm, might be better to delete it.
| import org.junit.jupiter.api.condition.DisabledIfSystemProperty; | ||
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
|
||
| @DisabledIfSystemProperty(named = "java.vm.name", matches = ".*OpenJ9.*") |
trask
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://develocity.opentelemetry.io/s/bvos6uz7aepse/tests/task/:instrumentation:hbase-client-2.0:javaagent:test/details/io.opentelemetry.javaagent.instrumentation.hbase.client.v2_0.HbaseClient20Test?expanded-stacktrace=WyIwLTEiXQ&top-execution=1