Skip to content

Fix daily workflow failure notifications#19001

Merged
trask merged 1 commit into
open-telemetry:mainfrom
trask:fix-daily-build-failure-issues
Jun 15, 2026
Merged

Fix daily workflow failure notifications#19001
trask merged 1 commit into
open-telemetry:mainfrom
trask:fix-daily-build-failure-issues

Conversation

@trask

@trask trask commented Jun 15, 2026

Copy link
Copy Markdown
Member

Fixes the daily workflow notification gap introduced by auto-reruns.

When a daily workflow fails, the normal workflow notification job is skipped until after the configured rerun attempts. If the separate rerun workflow decides not to rerun the workflow, for example because too many jobs failed, the notification job never gets another chance to create the issue.

@trask trask marked this pull request as ready for review June 15, 2026 16:06
@trask trask requested a review from a team as a code owner June 15, 2026 16:06
Copilot AI review requested due to automatic review settings June 15, 2026 16:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR closes a notification gap for failing daily workflows when the “rerun failed jobs” workflow decides not to rerun (or has exhausted rerun attempts), by having the rerun workflow open (or update) a GitHub issue directly.

Changes:

  • Grant issues: write permission to the daily rerun workflow so it can manage failure issues.
  • Update the rerun script to create an issue (or add a comment to an existing one) when reruns are skipped due to max attempts or too many failed jobs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/rerun-failed-daily-jobs.yml Adds issues: write so the rerun job can create/comment on issues.
.github/scripts/rerun-failed-workflow-jobs.py Opens/updates a workflow-failure issue when reruns are skipped.

Comment thread .github/scripts/rerun-failed-workflow-jobs.py
Comment thread .github/scripts/rerun-failed-workflow-jobs.py
@trask trask force-pushed the fix-daily-build-failure-issues branch from a15e68c to b1a1d63 Compare June 15, 2026 16:22
@trask trask requested a review from Copilot June 15, 2026 16:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@trask trask merged commit 3d1a5e6 into open-telemetry:main Jun 15, 2026
95 checks passed
@trask trask deleted the fix-daily-build-failure-issues branch June 15, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants