Skip to content

Fix test label comment workflow#19002

Merged
trask merged 1 commit into
open-telemetry:mainfrom
trask:remove-test-label-comment-workflow
Jun 15, 2026
Merged

Fix test label comment workflow#19002
trask merged 1 commit into
open-telemetry:mainfrom
trask:remove-test-label-comment-workflow

Conversation

@trask

@trask trask commented Jun 15, 2026

Copy link
Copy Markdown
Member

Updates the workflow that comments when test openj9 or test windows labels are applied.

The comment now explains that the extra action is only needed when the label was added after the current build started, since labels can also be present when the PR is first opened. The workflow also passes --repo "$GITHUB_REPOSITORY" to gh pr comment so it does not require a checked-out git repository context.

@trask trask force-pushed the remove-test-label-comment-workflow branch from 16e1cb5 to 77cbd9e Compare June 15, 2026 16:33
@trask trask changed the title Remove test label comment workflow Fix test label comment workflow Jun 15, 2026
@trask trask requested a review from Copilot June 15, 2026 16:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions workflow that posts a comment when test openj9 / test windows labels are applied, clarifying when action is needed for the label to be picked up by the PR build.

Changes:

  • Refines the workflow header documentation to explain that labels may already exist at PR open time.
  • Updates the posted comment text to clarify that a rebuild is only necessary if the label was added after the current build started.
  • Adds an explicit --repo argument to gh pr comment to avoid relying on a checked-out repository context.

Comment thread .github/workflows/comment-on-test-label.yml
@trask trask marked this pull request as ready for review June 15, 2026 16:50
@trask trask requested a review from a team as a code owner June 15, 2026 16:50
@trask trask enabled auto-merge (squash) June 15, 2026 17:17
@trask trask merged commit 65a62d0 into open-telemetry:main Jun 15, 2026
95 checks passed
@trask trask deleted the remove-test-label-comment-workflow branch June 15, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants