Skip to content

Improve Vert.x Redis stable metric test#19009

Merged
laurit merged 1 commit into
open-telemetry:mainfrom
trask:fix-vertx-redis-stable-metric-test
Jun 16, 2026
Merged

Improve Vert.x Redis stable metric test#19009
laurit merged 1 commit into
open-telemetry:mainfrom
trask:fix-vertx-redis-stable-metric-test

Conversation

@trask

@trask trask commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary

  • use the shared DB duration metric helper in the Vert.x Redis stable semconv test
  • assert the stable metric unit, description, histogram points, and expected attribute keys instead of checking only the metric name

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens the Vert.x Redis client stable semantic conventions metrics test by switching from a minimal “metric name exists” check to the shared DB client duration metric assertion helper, improving verification of metric metadata and datapoint attribute keys.

Changes:

  • Replace the ad-hoc stable-metric presence check with DbClientMetricsTestUtil.assertDurationMetric(...).
  • Expand the assertion to validate the stable metric’s unit, description, histogram shape, and expected attribute keys.

@trask trask marked this pull request as ready for review June 15, 2026 23:02
@trask trask requested a review from a team as a code owner June 15, 2026 23:02
@laurit laurit merged commit f35a444 into open-telemetry:main Jun 16, 2026
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants