Improve Vert.x SQL stable metric tests#19010
Merged
laurit merged 1 commit intoJun 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens the Vert.x SQL client stable semantic convention (stable semconv) metric tests by switching to the shared DB client duration metric assertion helper and validating metric metadata and attribute keys (not just metric name).
Changes:
- Replace ad-hoc
waitAndAssertMetrics(... hasName("db.client.operation.duration"))checks withDbClientMetricsTestUtil.assertDurationMetric(...). - Assert stable metric unit (
s), description, histogram structure, and that histogram point attributes contain only the expected semantic convention keys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| instrumentation/vertx/vertx-sql-client/vertx-sql-client-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/vertx/sqlclient/v5_0/VertxSqlClientTest.java | Use shared duration-metric helper and assert expected stable metric metadata + attribute keys. |
| instrumentation/vertx/vertx-sql-client/vertx-sql-client-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/vertx/sqlclient/v4_0/VertxSqlClientTest.java | Use shared duration-metric helper and assert expected stable metric metadata + attribute keys. |
laurit
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary