Set request timeout only for the read timeout test#19025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky highConcurrencyWithCallback() test in AsyncHttpClientCompletableFutureTest by setting the request timeout only for the read-timeout test, rather than applying it globally to all requests. Previously, the shared client configured a request timeout equal to the connection timeout (5s), which could cause spurious timeouts under high concurrency. Now, a second client instance with the read timeout is used exclusively for /read-timeout requests.
Changes:
- Introduce two separate
AsyncHttpClientinstances: one without a request timeout (default) and one with a read timeout, selected by agetClient(URI)method based on the request path. - Update
sendRequestandsendRequestWithCallbackin bothAsyncHttpClientTestandAsyncHttpClientCompletableFutureTestto route throughgetClient(uri)for client selection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
instrumentation/async-http-client/async-http-client-2.0/javaagent/src/test/java/…/AsyncHttpClientTest.java |
Adds two client instances, a buildClient factory, a getClient(URI) method for path-based client selection, and updates configureTimeout to conditionally set the request timeout. |
instrumentation/async-http-client/async-http-client-2.0/javaagent/src/test/java/…/AsyncHttpClientCompletableFutureTest.java |
Updates sendRequestWithCallback to use getClient(uri) instead of the direct client field. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jaydeluca
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully resolves https://develocity.opentelemetry.io/s/pk7tjfyd672c6/tests/task/:instrumentation:async-http-client:async-http-client-2.0:javaagent:testStableSemconv/details/io.opentelemetry.javaagent.instrumentation.asynchttpclient.v2_0.AsyncHttpClientCompletableFutureTest/highConcurrencyWithCallback()?expanded-stacktrace=WyIwIl0&top-execution=1