Skip to content

Suppress duplicate warning log for same application logger factory class #19088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhuvan-somisetty wants to merge 3 commits into
base: main
Choose a base branch
from
+53 −9
Open

Suppress duplicate warning log for same application logger factory class #19088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4cdb38
Suppress duplicate warning log for same application logger factory class
bhuvan-somisetty Jun 26, 2026
f1cba10
Fix race condition in ApplicationLoggerFactory same-class suppression
bhuvan-somisetty Jun 27, 2026
4beee51
Apply suggestion from @laurit
laurit Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...rc/main/java/io/opentelemetry/javaagent/logging/application/ApplicationLoggerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@
import io.opentelemetry.javaagent.bootstrap.logging.ApplicationLoggerBridge;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference;
import javax.annotation.Nullable;

final class ApplicationLoggerFactory extends ApplicationLoggerBridge
implements InternalLogger.Factory {

private final AtomicBoolean installed = new AtomicBoolean();
private final AtomicReference<Class<? extends InternalLogger.Factory>> installedFactoryClass =
new AtomicReference<>();
@Nullable private volatile InternalLogger.Factory actual = null;
private final ConcurrentMap<String, ApplicationLogger> inMemoryLoggers =
new ConcurrentHashMap<>();
Expand All @@ -28,8 +29,12 @@ final class ApplicationLoggerFactory extends ApplicationLoggerBridge

@Override
protected void install(InternalLogger.Factory applicationLoggerFactory) {
Class<? extends InternalLogger.Factory> incomingClass = applicationLoggerFactory.getClass();
// just use the first bridge that gets discovered and ignore the rest
if (!installed.compareAndSet(false, true)) {
if (!installedFactoryClass.compareAndSet(null, incomingClass)) {
if (incomingClass.equals(installedFactoryClass.get())) {
return;
}
applicationLoggerFactory
.create(ApplicationLoggerBridge.class.getName())
.log(
Expand Down
51 changes: 45 additions & 6 deletions ...est/java/io/opentelemetry/javaagent/logging/application/ApplicationLoggerFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.ArgumentMatchers.isNull;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
Expand Down Expand Up @@ -53,25 +54,49 @@ void shouldNotDuplicateLoggers() {

@Test
void shouldOnlyInstallTheFirstBridge() {
InternalLogger.Factory factory1 = mock(FirstFactory.class);
InternalLogger.Factory factory2 = mock(SecondFactory.class);

when(logStore.currentSize()).thenReturn(1, 0, 0);
when(applicationLoggerBridge.create(any())).thenReturn(applicationLogger);
when(factory2.create(any())).thenReturn(applicationLogger);

underTest.install(applicationLoggerBridge);
underTest.install(factory1);

verify(logStore, times(3)).currentSize();
verify(logStore).flush(applicationLoggerBridge);
verify(logStore).setApplicationLoggerFactory(applicationLoggerBridge);
verify(logStore).flush(factory1);
verify(logStore).setApplicationLoggerFactory(factory1);
verify(logStore).freeMemory();

underTest.install(applicationLoggerBridge);
underTest.install(factory2);

// verify logged warning
verify(applicationLoggerBridge).create(ApplicationLoggerBridge.class.getName());
verify(factory2).create(ApplicationLoggerBridge.class.getName());
verify(applicationLogger).log(eq(WARN), anyString(), isNull());

verifyNoMoreInteractions(logStore);
}

@Test
void shouldIgnoreSubsequentInstallationsOfSameClass() {
InternalLogger.Factory factory1 = mock(FirstFactory.class);
InternalLogger.Factory factory2 = mock(FirstFactory.class);

when(logStore.currentSize()).thenReturn(1, 0, 0);

underTest.install(factory1);

verify(logStore, times(3)).currentSize();
verify(logStore).flush(factory1);
verify(logStore).setApplicationLoggerFactory(factory1);
verify(logStore).freeMemory();

underTest.install(factory2);

// verify no warning logged and no factory interaction for second install
verify(factory2, never()).create(anyString());
verifyNoMoreInteractions(logStore);
}

@Test
void shouldReplaceLoggerAfterTheBridgeIsInstalled() {
InternalLogger beforeInstall = underTest.create("logger");
Expand All @@ -90,4 +115,18 @@ void shouldReplaceLoggerAfterTheBridgeIsInstalled() {
verify(applicationLogger).log(INFO, "after", null);
verify(logStore, never()).write(InMemoryLog.create("logger", INFO, "after", null));
}

static class FirstFactory implements InternalLogger.Factory {
@Override
public InternalLogger create(String name) {
return null;
}
}

static class SecondFactory implements InternalLogger.Factory {
@Override
public InternalLogger create(String name) {
return null;
}
}
}
Loading