Skip to content

Commit 16e1492

Browse files
committed
move logic to incubating util
1 parent f86f89b commit 16e1492

File tree

5 files changed

+26
-148
lines changed

5 files changed

+26
-148
lines changed

sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/IncubatingUtil.java

Lines changed: 26 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
import io.opentelemetry.api.incubator.config.DeclarativeConfigException;
1212
import io.opentelemetry.api.incubator.config.GlobalConfigProvider;
1313
import io.opentelemetry.common.ComponentLoader;
14+
import io.opentelemetry.sdk.OpenTelemetrySdk;
1415
import io.opentelemetry.sdk.autoconfigure.spi.ConfigurationException;
16+
import io.opentelemetry.sdk.resources.Resource;
1517
import java.io.FileInputStream;
1618
import java.io.FileNotFoundException;
1719
import java.io.IOException;
@@ -98,11 +100,32 @@ private static AutoConfiguredOpenTelemetrySdk getOpenTelemetrySdk(
98100
Class<?> declarativeConfiguration =
99101
Class.forName(
100102
"io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration");
103+
104+
Class<?> contextClass =
105+
Class.forName(
106+
"io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigContext");
107+
Method createContext = contextClass.getDeclaredMethod("create", ComponentLoader.class);
108+
createContext.setAccessible(true);
109+
Object context = createContext.invoke(null, componentLoader);
110+
101111
Method create =
102-
declarativeConfiguration.getMethod(
103-
"createAutoConfiguredSdk", openTelemetryConfiguration, ComponentLoader.class);
112+
declarativeConfiguration.getDeclaredMethod(
113+
"create", openTelemetryConfiguration, contextClass);
114+
create.setAccessible(true);
115+
OpenTelemetrySdk sdk = (OpenTelemetrySdk) create.invoke(null, model, context);
116+
117+
Class<?> providerClass =
118+
Class.forName("io.opentelemetry.sdk.extension.incubator.fileconfig.SdkConfigProvider");
119+
Object provider =
120+
providerClass
121+
.getDeclaredMethod("create", openTelemetryConfiguration, ComponentLoader.class)
122+
.invoke(null, model, componentLoader);
123+
124+
Method getResource = contextClass.getDeclaredMethod("getResource");
125+
getResource.setAccessible(true);
126+
Resource resource = (Resource) getResource.invoke(context);
104127

105-
return (AutoConfiguredOpenTelemetrySdk) create.invoke(null, model, componentLoader);
128+
return AutoConfiguredOpenTelemetrySdk.create(sdk, resource, null, provider);
106129
}
107130

108131
// Visible for testing

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AutoConfiguredOpenTelemetrySdkAccess.java

Lines changed: 0 additions & 71 deletions
This file was deleted.

sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfiguration.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
1414
import io.opentelemetry.common.ComponentLoader;
1515
import io.opentelemetry.sdk.OpenTelemetrySdk;
16-
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
1716
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
1817
import io.opentelemetry.sdk.autoconfigure.spi.internal.AutoConfigureListener;
1918
import io.opentelemetry.sdk.autoconfigure.spi.internal.ComponentProvider;
@@ -138,15 +137,6 @@ private static ExtendedOpenTelemetrySdk create(
138137
return sdk;
139138
}
140139

141-
public static AutoConfiguredOpenTelemetrySdk createAutoConfiguredSdk(
142-
OpenTelemetryConfigurationModel configurationModel, ComponentLoader componentLoader) {
143-
DeclarativeConfigContext context = DeclarativeConfigContext.create(componentLoader);
144-
OpenTelemetrySdk sdk = create(configurationModel, context);
145-
SdkConfigProvider provider = SdkConfigProvider.create(configurationModel, componentLoader);
146-
147-
return AutoConfiguredOpenTelemetrySdkAccess.create(sdk, context.getResource(), provider);
148-
}
149-
150140
/**
151141
* Parse the {@code configuration} YAML and return the {@link OpenTelemetryConfigurationModel}.
152142
*

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/AutoConfiguredOpenTelemetrySdkAccessTest.java

Lines changed: 0 additions & 42 deletions
This file was deleted.

sdk-extensions/incubator/src/test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfigurationCreateTest.java

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import io.opentelemetry.common.ComponentLoader;
1919
import io.opentelemetry.internal.testing.CleanupExtension;
2020
import io.opentelemetry.sdk.OpenTelemetrySdk;
21-
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
2221
import io.opentelemetry.sdk.autoconfigure.internal.SpiHelper;
2322
import io.opentelemetry.sdk.extension.incubator.ExtendedOpenTelemetrySdk;
2423
import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.OpenTelemetryConfigurationModel;
@@ -195,25 +194,4 @@ void callAutoConfigureListeners_exceptionIsCaught() {
195194
spiHelper, OpenTelemetrySdk.builder().build()))
196195
.doesNotThrowAnyException();
197196
}
198-
199-
@Test
200-
void createAutoConfiguredSdk() {
201-
OpenTelemetryConfigurationModel model = new OpenTelemetryConfigurationModel();
202-
model.withFileFormat("1.0-rc.1");
203-
AutoConfiguredOpenTelemetrySdk sdk =
204-
DeclarativeConfiguration.createAutoConfiguredSdk(
205-
model,
206-
// customizer is TestDeclarativeConfigurationCustomizerProvider
207-
ComponentLoader.forClassLoader(
208-
DeclarativeConfigurationCreateTest.class.getClassLoader()));
209-
assertThat(sdk.toString())
210-
.contains(
211-
"resource=Resource{schemaUrl=null, attributes={"
212-
+ "color=\"blue\", "
213-
+ "foo=\"bar\", "
214-
+ "service.name=\"unknown_service:java\", "
215-
+ "telemetry.sdk.language=\"java\", "
216-
+ "telemetry.sdk.name=\"opentelemetry\", "
217-
+ "telemetry.sdk.version=\"");
218-
}
219197
}

0 commit comments

Comments
 (0)