Skip to content

Commit 45df14d

Browse files
more permissive test case
PrometheusMetricReaderProviderTest createMetricReader_Default is currently only testing for ipv6 0:0:0:0:0:0:0:0 and doesn't test for any other potential return values from getAddress
1 parent e8920e7 commit 45df14d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

exporters/prometheus/src/test/java/io/opentelemetry/exporter/prometheus/internal/PrometheusMetricReaderProviderTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ void createMetricReader_Default() throws IOException {
5959
.extracting("server", as(InstanceOfAssertFactories.type(HttpServer.class)))
6060
.satisfies(
6161
server -> {
62-
assertThat(server.getAddress().getHostName()).isEqualTo("0:0:0:0:0:0:0:0");
62+
assertThat(server.getAddress().getHostName())
63+
.isIn("localhost", "127.0.0.1", "kubernetes.docker.internal", "0:0:0:0:0:0:0:0", "0.0.0.0");
6364
assertThat(server.getAddress().getPort()).isEqualTo(9464);
6465
});
6566
assertThat(metricReader.getMemoryMode()).isEqualTo(MemoryMode.REUSABLE_DATA);

0 commit comments

Comments
 (0)