Skip to content

Commit 950fb89

Browse files
committed
ci: keep flint scoped to link checks
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
1 parent 9281a36 commit 950fb89

4 files changed

Lines changed: 28 additions & 22 deletions

File tree

.github/workflows/build-daily.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ permissions:
1010
contents: read
1111

1212
jobs:
13-
lint:
14-
uses: ./.github/workflows/reusable-lint-check.yml
13+
link-check:
14+
uses: ./.github/workflows/reusable-link-check.yml
1515

1616
publish-snapshots:
1717
runs-on: ubuntu-24.04
@@ -42,13 +42,13 @@ jobs:
4242
contents: read
4343
issues: write
4444
needs:
45-
- lint
45+
- link-check
4646
- publish-snapshots
4747
if: always()
4848
uses: ./.github/workflows/reusable-workflow-notification.yml
4949
with:
5050
success: >-
5151
${{
52-
needs.lint.result == 'success' &&
52+
needs.link-check.result == 'success' &&
5353
needs.publish-snapshots.result == 'success'
5454
}}

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,10 @@ jobs:
9999
name: coverage-report
100100
path: all/build/reports/jacoco/test/html
101101

102-
lint:
102+
markdown-link-check:
103103
# release branches are excluded to avoid unnecessary maintenance
104104
if: ${{ !startsWith(github.ref_name, 'release/') }}
105-
uses: ./.github/workflows/reusable-lint-check.yml
105+
uses: ./.github/workflows/reusable-link-check.yml
106106

107107
build-graal:
108108
name: Build GraalVM
@@ -136,7 +136,7 @@ jobs:
136136
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
137137

138138
required-status-check:
139-
# lint is not required so pull requests are not blocked if external links break
139+
# markdown-link-check is not required so pull requests are not blocked if external links break
140140
needs:
141141
- build
142142
- build-graal
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Reusable - Lint check
1+
name: Reusable - Link check
22

33
on:
44
workflow_call:
@@ -7,7 +7,7 @@ permissions:
77
contents: read
88

99
jobs:
10-
lint-check:
10+
link-check:
1111
runs-on: ubuntu-latest
1212
steps:
1313
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -16,18 +16,18 @@ jobs:
1616

1717
- uses: jdx/mise-action@1648a7812b9aeae629881980618f079932869151 # v4.0.1
1818

19-
- name: Lint for pull requests
19+
- name: Link check for pull requests
2020
if: github.event_name == 'pull_request'
2121
env:
2222
GITHUB_TOKEN: ${{ github.token }}
2323
GITHUB_REPOSITORY: ${{ github.repository }}
2424
GITHUB_BASE_REF: ${{ github.base_ref }}
2525
GITHUB_HEAD_REF: ${{ github.head_ref }}
2626
PR_HEAD_REPO: ${{ github.event.pull_request.head.repo.full_name }}
27-
run: mise run lint
27+
run: mise run lint:links
2828

29-
- name: Lint for pushes and scheduled workflows
29+
- name: Link check for pushes and scheduled workflows
3030
if: github.event_name != 'pull_request'
3131
env:
3232
GITHUB_TOKEN: ${{ github.token }}
33-
run: mise run lint --full
33+
run: mise run lint:links --full

mise.toml

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,20 @@
44
"github:grafana/flint" = "0.21.0"
55
lychee = "0.23.0"
66

7-
[tasks.lint]
8-
description = "Run link checks"
9-
raw_args = true
10-
run = "flint run"
11-
12-
[tasks."lint:fix"]
13-
description = "Auto-fix lint issues"
14-
run = "flint run --fix"
15-
167
[env]
178
FLINT_CONFIG_DIR = ".github/config"
9+
10+
[settings]
11+
# Only install tools explicitly defined in the [tools] section above
12+
idiomatic_version_file_enable_tools = []
13+
14+
# Windows configuration for file-based tasks
15+
# Based on: https://github.com/jdx/mise/discussions/4461
16+
windows_executable_extensions = ["sh"]
17+
windows_default_file_shell_args = "bash"
18+
use_file_shell_for_executable_tasks = true
19+
20+
[tasks."lint:links"]
21+
description = "Check for broken links in changed files + all local links"
22+
raw_args = true
23+
run = "flint run"

0 commit comments

Comments
 (0)