fix: narrow flush fix to span exporter

Author: ADITYA-CODE-SOURCE

exporters/logging/src/main/java/io/opentelemetry/exporter/logging/LoggingMetricExporter.java

@@ -84,14 +84,15 @@ public CompletableResultCode export(Collection<MetricData> metrics) {
    */
   @Override
   public CompletableResultCode flush() {
+    CompletableResultCode resultCode = new CompletableResultCode();
     for (Handler handler : logger.getHandlers()) {
       try {
         handler.flush();
       } catch (Throwable t) {
-        return CompletableResultCode.ofFailure();
+        return resultCode.fail();
       }
     }
-    return CompletableResultCode.ofSuccess();
+    return resultCode.succeed();
   }
 
   @Override

exporters/logging/src/main/java/io/opentelemetry/exporter/logging/LoggingSpanExporter.java

@@ -74,14 +74,15 @@ public CompletableResultCode export(Collection<SpanData> spans) {
    */
   @Override
   public CompletableResultCode flush() {
+    CompletableResultCode resultCode = new CompletableResultCode();
     for (Handler handler : logger.getHandlers()) {
       try {
         handler.flush();
       } catch (Throwable t) {
-        return CompletableResultCode.ofFailure();
+        return resultCode.fail();
       }
     }
-    return CompletableResultCode.ofSuccess();
+    return resultCode.succeed();
   }
 
   @Override

exporters/logging/src/test/java/io/opentelemetry/exporter/logging/LoggingMetricExporterTest.java

@@ -25,7 +25,6 @@
 import java.util.Collections;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
-import java.util.logging.Handler;
 import java.util.logging.Logger;
 import java.util.logging.SimpleFormatter;
 import java.util.logging.StreamHandler;
@@ -103,19 +102,20 @@ public synchronized void flush() {
   }
 
   @Test
-  void flush_failure() {
-    Handler failingHandler =
+  void flushFailure() {
+    Logger logger = Logger.getLogger(LoggingMetricExporter.class.getName());
+    StreamHandler failingHandler =
         new StreamHandler(new PrintStream(new ByteArrayOutputStream()), new SimpleFormatter()) {
           @Override
           public synchronized void flush() {
             throw new RuntimeException("Flush failed");
           }
         };
-    Logger.getLogger(LoggingMetricExporter.class.getName()).addHandler(failingHandler);
+    logger.addHandler(failingHandler);
     try {
       assertThat(exporter.flush().isSuccess()).isFalse();
     } finally {
-      Logger.getLogger(LoggingMetricExporter.class.getName()).removeHandler(failingHandler);
+      logger.removeHandler(failingHandler);
     }
   }
 

exporters/logging/src/test/java/io/opentelemetry/exporter/logging/LoggingSpanExporterTest.java

@@ -31,7 +31,6 @@
 import java.util.Collections;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
-import java.util.logging.Handler;
 import java.util.logging.Logger;
 import java.util.logging.SimpleFormatter;
 import java.util.logging.StreamHandler;
@@ -141,19 +140,20 @@ public synchronized void flush() {
   }
 
   @Test
-  void flush_failure() {
-    Handler failingHandler =
+  void flushFailure() {
+    Logger logger = Logger.getLogger(LoggingSpanExporter.class.getName());
+    StreamHandler failingHandler =
         new StreamHandler(new PrintStream(new ByteArrayOutputStream()), new SimpleFormatter()) {
           @Override
           public synchronized void flush() {
             throw new RuntimeException("Flush failed");
           }
         };
-    Logger.getLogger(LoggingSpanExporter.class.getName()).addHandler(failingHandler);
+    logger.addHandler(failingHandler);
     try {
       assertThat(exporter.flush().isSuccess()).isFalse();
     } finally {
-      Logger.getLogger(LoggingSpanExporter.class.getName()).removeHandler(failingHandler);
+      logger.removeHandler(failingHandler);
     }
   }