Response body bounds (#8224)

Author: jack-berg

docs/apidiffs/current_vs_latest/opentelemetry-sdk-common.txt

@@ -1,2 +1,7 @@
 Comparing source compatibility of opentelemetry-sdk-common-1.61.0-SNAPSHOT.jar against opentelemetry-sdk-common-1.60.1.jar
-No changes.
+***  MODIFIED INTERFACE: PUBLIC ABSTRACT io.opentelemetry.sdk.common.export.GrpcSenderConfig  (not serializable)
+	===  CLASS FILE FORMAT VERSION: 52.0 <- 52.0
+	+++  NEW METHOD: PUBLIC(+) long getMaxResponseBodySize()
+***  MODIFIED INTERFACE: PUBLIC ABSTRACT io.opentelemetry.sdk.common.export.HttpSenderConfig  (not serializable)
+	===  CLASS FILE FORMAT VERSION: 52.0 <- 52.0
+	+++  NEW METHOD: PUBLIC(+) long getMaxResponseBodySize()

docs/apidiffs/current_vs_latest/opentelemetry-sdk-extension-jaeger-remote-sampler.txt

@@ -1,2 +1,4 @@
 Comparing source compatibility of opentelemetry-sdk-extension-jaeger-remote-sampler-1.61.0-SNAPSHOT.jar against opentelemetry-sdk-extension-jaeger-remote-sampler-1.60.1.jar
-No changes.
+***  MODIFIED CLASS: PUBLIC FINAL io.opentelemetry.sdk.extension.trace.jaeger.sampler.JaegerRemoteSamplerBuilder  (not serializable)
+	===  CLASS FILE FORMAT VERSION: 52.0 <- 52.0
+	+++  NEW METHOD: PUBLIC(+) io.opentelemetry.sdk.extension.trace.jaeger.sampler.JaegerRemoteSamplerBuilder setMaxSamplingStrategyResponseBodySize(long)

exporters/common/src/main/java/io/opentelemetry/exporter/internal/grpc/GrpcExporterBuilder.java

@@ -230,7 +230,10 @@ public GrpcExporter build() {
                 isPlainHttp ? null : tlsConfigHelper.getSslContext(),
                 isPlainHttp ? null : tlsConfigHelper.getTrustManager(),
                 executorService,
-                grpcChannel));
+                grpcChannel,
+                // 4mb to align with spec guidance - even though we don't do anything with the
+                // response today, we will so better to have future-looking memory profile
+                4 * 1024L * 1024L));
     LOGGER.log(Level.FINE, "Using GrpcSender: " + grpcSender.getClass().getName());
 
     return new GrpcExporter(

exporters/common/src/main/java/io/opentelemetry/exporter/internal/grpc/ImmutableGrpcSenderConfig.java

@@ -37,7 +37,8 @@ public static ImmutableGrpcSenderConfig create(
       @Nullable SSLContext sslContext,
       @Nullable X509TrustManager trustManager,
       @Nullable ExecutorService executorService,
-      @Nullable Object managedChannel) {
+      @Nullable Object managedChannel,
+      long maxResponseBodySize) {
     return new AutoValue_ImmutableGrpcSenderConfig(
         endpoint,
         fullMethodName,
@@ -49,6 +50,10 @@ public static ImmutableGrpcSenderConfig create(
         sslContext,
         trustManager,
         executorService,
-        managedChannel);
+        managedChannel,
+        maxResponseBodySize);
   }
+
+  @Override
+  public abstract long getMaxResponseBodySize();
 }

exporters/common/src/main/java/io/opentelemetry/exporter/internal/http/HttpExporterBuilder.java

@@ -245,7 +245,10 @@ public HttpExporter build() {
                 retryPolicy,
                 isPlainHttp ? null : tlsConfigHelper.getSslContext(),
                 isPlainHttp ? null : tlsConfigHelper.getTrustManager(),
-                executorService));
+                executorService,
+                // 4mb to align with spec guidance - even though we don't do anything with the
+                // response today, we will so better to have future-looking memory profile
+                4 * 1024L * 1024L));
     LOGGER.log(Level.FINE, "Using HttpSender: " + httpSender.getClass().getName());
 
     return new HttpExporter(

exporters/common/src/main/java/io/opentelemetry/exporter/internal/http/ImmutableHttpSenderConfig.java

@@ -35,7 +35,8 @@ static HttpSenderConfig create(
       @Nullable RetryPolicy retryPolicy,
       @Nullable SSLContext sslContext,
       @Nullable X509TrustManager trustManager,
-      @Nullable ExecutorService executorService) {
+      @Nullable ExecutorService executorService,
+      long maxResponseBodySize) {
     return new AutoValue_ImmutableHttpSenderConfig(
         endpoint,
         contentType,
@@ -47,6 +48,10 @@ static HttpSenderConfig create(
         retryPolicy,
         sslContext,
         trustManager,
-        executorService);
+        executorService,
+        maxResponseBodySize);
   }
+
+  @Override
+  public abstract long getMaxResponseBodySize();
 }

exporters/common/src/test/java/io/opentelemetry/exporter/internal/grpc/GrpcExporterTest.java

@@ -28,6 +28,7 @@
 import java.net.URI;
 import java.time.Duration;
 import java.util.function.Consumer;
+import javax.annotation.Nullable;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.EnumSource;
@@ -120,8 +121,7 @@ void testInternalTelemetry(StandardComponentId.ExporterType exporterType) {
                                                     pa.hasAttributes(expectedAttributes)
                                                         .hasValue(42))));
 
-                onResponse.accept(
-                    ImmutableGrpcResponse.create(GrpcStatusCode.OK, null, new byte[0]));
+                onResponse.accept(grpcResponse(GrpcStatusCode.OK));
 
                 return null;
               })
@@ -133,7 +133,7 @@ void testInternalTelemetry(StandardComponentId.ExporterType exporterType) {
       doAnswer(
               invoc -> {
                 Consumer<GrpcResponse> onResponse = invoc.getArgument(1);
-                onResponse.accept(ImmutableGrpcResponse.create(UNAVAILABLE, null, new byte[0]));
+                onResponse.accept(grpcResponse(UNAVAILABLE));
 
                 return null;
               })
@@ -224,4 +224,24 @@ void testInternalTelemetry(StandardComponentId.ExporterType exporterType) {
                                           .hasBucketCounts(1))));
     }
   }
+
+  private static GrpcResponse grpcResponse(GrpcStatusCode statusCode) {
+    return new GrpcResponse() {
+      @Override
+      public GrpcStatusCode getStatusCode() {
+        return statusCode;
+      }
+
+      @Override
+      @Nullable
+      public String getStatusDescription() {
+        return null;
+      }
+
+      @Override
+      public byte[] getResponseMessage() {
+        return new byte[0];
+      }
+    };
+  }
 }

exporters/otlp/all/src/jmh/java/io/opentelemetry/exporter/otlp/trace/OltpExporterBenchmark.java

@@ -110,7 +110,8 @@ public void setUp() {
                 null,
                 null,
                 null,
-                null),
+                null,
+                Long.MAX_VALUE),
             InternalTelemetryVersion.LATEST,
             ComponentId.generateLazy(StandardComponentId.ExporterType.OTLP_GRPC_SPAN_EXPORTER),
             MeterProvider::noop,

exporters/otlp/profiles/src/test/java/io/opentelemetry/exporter/otlp/profiles/OtlpGrpcProfileExporterTest.java

@@ -42,7 +42,7 @@ void usingOkHttp() throws Exception {
   @Override // whilst profile signal type is in development it uses a different error message
   @SuppressLogger(GrpcExporter.class)
   protected void testExport_Unimplemented() {
-    addGrpcError(GrpcStatusCode.UNIMPLEMENTED, "UNIMPLEMENTED");
+    addGrpcResponse(GrpcStatusCode.UNIMPLEMENTED, "UNIMPLEMENTED");
 
     TelemetryExporter<ProfileData> exporter = nonRetryingExporter();