Fix inverted condition in LegacySpanProcessorInstrumentation#finishSpans (#8145)

antonio-mazzini · web-flow · commit e8920e7ca671 · 2026-03-06T08:27:28.000-06:00
diff --git a/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/LegacySpanProcessorInstrumentation.java b/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/LegacySpanProcessorInstrumentation.java
@@ -58,7 +58,7 @@ public void dropSpans(int count) {
   @Override
   public void finishSpans(int count, @Nullable String error) {
     // Legacy metrics only record when no error.
-    if (error != null) {
+    if (error == null) {
       processedSpans().add(count, standardAttrs);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public void dropSpans(int count) {`
`58`	`58`	`@Override`
`59`	`59`	`public void finishSpans(int count, @Nullable String error) {`
`60`	`60`	`// Legacy metrics only record when no error.`
`61`		`- if (error != null) {`
	`61`	`+ if (error == null) {`
`62`	`62`	`processedSpans().add(count, standardAttrs);`
`63`	`63`	`}`
`64`	`64`	`}`