opencensus-shim

Author: trask

opencensus-shim/src/main/java/io/opentelemetry/opencensusshim/DelegatingSpan.java

@@ -8,6 +8,7 @@
 import com.google.errorprone.annotations.MustBeClosed;
 import io.opentelemetry.api.common.AttributeKey;
 import io.opentelemetry.api.common.Attributes;
+import io.opentelemetry.api.common.Value;
 import io.opentelemetry.api.trace.Span;
 import io.opentelemetry.api.trace.SpanContext;
 import io.opentelemetry.api.trace.StatusCode;
@@ -77,6 +78,11 @@ default Span setAttribute(String key, boolean value) {
     return getDelegate().setAttribute(key, value);
   }
 
+  @Override
+  default Span setAttribute(String key, Value<?> value) {
+    return getDelegate().setAttribute(key, value);
+  }
+
   @Override
   default Span setAttribute(AttributeKey<Long> key, int value) {
     return getDelegate().setAttribute(key, value);

opencensus-shim/src/main/java/io/opentelemetry/opencensusshim/OpenTelemetryNoRecordEventsSpanImpl.java

@@ -33,6 +33,7 @@
 import io.opencensus.trace.Status;
 import io.opentelemetry.api.common.AttributeKey;
 import io.opentelemetry.api.common.Attributes;
+import io.opentelemetry.api.common.Value;
 import io.opentelemetry.api.trace.StatusCode;
 import java.util.EnumSet;
 import java.util.Map;
@@ -129,6 +130,11 @@ public io.opentelemetry.api.trace.Span setAttribute(String key, boolean value) {
     return this;
   }
 
+  @Override
+  public io.opentelemetry.api.trace.Span setAttribute(String key, Value<?> value) {
+    return this;
+  }
+
   @Override
   public <T> io.opentelemetry.api.trace.Span setAttribute(AttributeKey<T> key, @Nullable T value) {
     return this;

opencensus-shim/src/test/java/io/opentelemetry/opencensusshim/DelegatingSpanTest.java

@@ -10,6 +10,7 @@
 
 import io.opentelemetry.api.common.AttributeKey;
 import io.opentelemetry.api.common.Attributes;
+import io.opentelemetry.api.common.Value;
 import io.opentelemetry.api.trace.Span;
 import io.opentelemetry.api.trace.SpanContext;
 import io.opentelemetry.api.trace.StatusCode;
@@ -95,6 +96,7 @@ static Stream<Arguments> delegateMethodsProvider() {
         Arguments.of("setAttribute", new Class<?>[] {String.class, long.class}, times(1)),
         Arguments.of("setAttribute", new Class<?>[] {String.class, double.class}, times(1)),
         Arguments.of("setAttribute", new Class<?>[] {String.class, boolean.class}, times(1)),
+        Arguments.of("setAttribute", new Class<?>[] {String.class, Value.class}, times(1)),
         Arguments.of(
             "recordException", new Class<?>[] {Throwable.class, Attributes.class}, times(1)),
         Arguments.of("recordException", new Class<?>[] {Throwable.class}, times(1)),

opencensus-shim/src/test/java/io/opentelemetry/opencensusshim/OpenTelemetryNoRecordEventsSpanImplTest.java

@@ -38,6 +38,7 @@
 import io.opencensus.trace.Tracestate;
 import io.opentelemetry.api.common.AttributeKey;
 import io.opentelemetry.api.common.Attributes;
+import io.opentelemetry.api.common.Value;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Random;
@@ -93,6 +94,7 @@ public void doNotCrash() {
     noRecordEventsSpan.setAttribute("OTelAttributeKeyLong", 123);
     noRecordEventsSpan.setAttribute("OTelAttributeKeyDouble", 123.45);
     noRecordEventsSpan.setAttribute("OTelAttributeKeyBoolean", true);
+    noRecordEventsSpan.setAttribute("OTelAttributeKeyValue", Value.empty());
     noRecordEventsSpan.addEvent("OTel event 1");
     noRecordEventsSpan.addEvent("OTel event 2", 29922310, TimeUnit.HOURS);
     noRecordEventsSpan.addEvent(