Make snakeyaml-engine and jackson-databind optional at runtime

Split DeclarativeConfiguration into two classes:
- DeclarativeConfiguration: create(model) only, no YAML/jackson-databind deps
- DeclarativeConfigurationParser: all parsing (MAPPER static block, parse,
  loadYaml, parseAndCreate, toConfigProperties, createSampler, env-var
  substitution, snakeyaml inner classes)

Change snakeyaml-engine and jackson-databind from implementation to
compileOnly in build.gradle.kts (keeping jackson-annotations as api since
the generated model POJOs use @JsonProperty etc. as public API).
Remove the unused jackson-dataformat-yaml dependency.

Users who only call DeclarativeConfiguration.create(model) for programmatic
SDK configuration no longer incur transitive YAML/jackson-databind deps.
Users who need YAML parsing add snakeyaml-engine and jackson-databind and
call DeclarativeConfigurationParser.parseAndCreate(stream).

This also opens the door for merging declarative config into autoconfigure,
since the static initializer that caused NoClassDefFoundError when
jackson-databind was absent is now isolated in DeclarativeConfigurationParser.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>

Author: zeitlinger

api/incubator/src/test/java/io/opentelemetry/api/incubator/ExtendedOpenTelemetryTest.java

@@ -25,7 +25,7 @@
 import io.opentelemetry.api.trace.TracerProvider;
 import io.opentelemetry.context.propagation.ContextPropagators;
 import io.opentelemetry.sdk.OpenTelemetrySdk;
-import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
+import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationParser;
 import io.opentelemetry.sdk.internal.ExtendedOpenTelemetrySdk;
 import io.opentelemetry.sdk.internal.SdkConfigProvider;
 import java.io.ByteArrayInputStream;
@@ -94,7 +94,7 @@ void instrumentationConfig() {
 
     SdkConfigProvider configProvider =
         SdkConfigProvider.create(
-            DeclarativeConfiguration.toConfigProperties(
+            DeclarativeConfigurationParser.toConfigProperties(
                 new ByteArrayInputStream(configYaml.getBytes(StandardCharsets.UTF_8))));
     ExtendedOpenTelemetry openTelemetry =
         ExtendedOpenTelemetrySdk.create(OpenTelemetrySdk.builder().build(), configProvider);

api/incubator/src/test/java/io/opentelemetry/api/incubator/config/InstrumentationConfigUtilTest.java

@@ -8,7 +8,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import com.google.common.collect.ImmutableMap;
-import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
+import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationParser;
 import io.opentelemetry.sdk.extension.incubator.fileconfig.YamlDeclarativeConfigProperties;
 import io.opentelemetry.sdk.internal.SdkConfigProvider;
 import java.io.ByteArrayInputStream;
@@ -61,7 +61,7 @@ class InstrumentationConfigUtilTest {
 
   private static ConfigProvider toConfigProvider(String configYaml) {
     return SdkConfigProvider.create(
-        DeclarativeConfiguration.toConfigProperties(
+        DeclarativeConfigurationParser.toConfigProperties(
             new ByteArrayInputStream(configYaml.getBytes(StandardCharsets.UTF_8))));
   }
 

api/incubator/src/testConvertToModel/java/io/opentelemetry/api/incubator/InstrumentationConfigUtilTest.java

@@ -14,7 +14,7 @@
 import io.opentelemetry.api.incubator.config.ConfigProvider;
 import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
 import io.opentelemetry.api.incubator.config.InstrumentationConfigUtil;
-import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
+import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationParser;
 import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalInstrumentationModel;
 import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalLanguageSpecificInstrumentationModel;
 import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.ExperimentalLanguageSpecificInstrumentationPropertyModel;
@@ -54,7 +54,7 @@ void toMap_RoundTrip() throws JsonProcessingException {
 
     String mapJson = MAPPER.writeValueAsString(map);
     DeclarativeConfigProperties properties =
-        DeclarativeConfiguration.toConfigProperties(
+        DeclarativeConfigurationParser.toConfigProperties(
             new ByteArrayInputStream(mapJson.getBytes(StandardCharsets.UTF_8)));
 
     assertThat(DeclarativeConfigProperties.toMap(properties)).isEqualTo(map);
@@ -131,7 +131,7 @@ private static ConfigProvider withInstrumentationConfig(
         new ExperimentalLanguageSpecificInstrumentationModel();
     javaConfig.setAdditionalProperty(instrumentationName, instrumentationConfig);
     DeclarativeConfigProperties modelProperties =
-        DeclarativeConfiguration.toConfigProperties(
+        DeclarativeConfigurationParser.toConfigProperties(
             new OpenTelemetryConfigurationModel()
                 .withInstrumentationDevelopment(
                     new ExperimentalInstrumentationModel().withJava(javaConfig)));

integration-tests/graal-incubating/src/test/java/io/opentelemetry/integrationtests/graal/IncubatingApiTests.java

@@ -23,7 +23,7 @@
 import io.opentelemetry.api.metrics.Meter;
 import io.opentelemetry.api.metrics.MeterProvider;
 import io.opentelemetry.api.trace.TracerProvider;
-import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
+import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationParser;
 import io.opentelemetry.sdk.logs.SdkLoggerProvider;
 import io.opentelemetry.sdk.logs.export.SimpleLogRecordProcessor;
 import io.opentelemetry.sdk.metrics.SdkMeterProvider;
@@ -124,7 +124,7 @@ void parseDeclarativeConfiguration() {
                 drop: {}
       """;
     // should not throw
-    DeclarativeConfiguration.parse(
+    DeclarativeConfigurationParser.parse(
         new ByteArrayInputStream(string.getBytes(StandardCharsets.UTF_8)));
   }
 }

sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/IncubatingUtil.java

@@ -12,6 +12,7 @@
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigurationException;
 import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigResult;
 import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
+import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationParser;
 import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationProvider;
 import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.OpenTelemetryConfigurationModel;
 import java.io.FileInputStream;
@@ -35,7 +36,7 @@ static AutoConfiguredOpenTelemetrySdk configureFromFile(
       Logger logger, String configurationFile, ComponentLoader componentLoader) {
     logger.fine("Autoconfiguring from configuration file: " + configurationFile);
     try (FileInputStream fis = new FileInputStream(configurationFile)) {
-      OpenTelemetryConfigurationModel model = DeclarativeConfiguration.parse(fis);
+      OpenTelemetryConfigurationModel model = DeclarativeConfigurationParser.parse(fis);
       return create(model, componentLoader);
     } catch (DeclarativeConfigException e) {
       throw toConfigurationException(e);

sdk-extensions/autoconfigure/src/testDeclarativeConfigSpi/java/io/opentelemetry/sdk/autoconfigure/TestDeclarativeConfigurationProvider.java

@@ -5,7 +5,7 @@
 
 package io.opentelemetry.sdk.autoconfigure;
 
-import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfiguration;
+import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationParser;
 import io.opentelemetry.sdk.extension.incubator.fileconfig.DeclarativeConfigurationProvider;
 import io.opentelemetry.sdk.extension.incubator.fileconfig.internal.model.OpenTelemetryConfigurationModel;
 import java.io.ByteArrayInputStream;
@@ -29,7 +29,7 @@ public OpenTelemetryConfigurationModel getConfigurationModel() {
             + "        exporter:\n"
             + "          console: {}\n";
 
-    return DeclarativeConfiguration.parse(
+    return DeclarativeConfigurationParser.parse(
         new ByteArrayInputStream(yaml.getBytes(StandardCharsets.UTF_8)));
   }
 }

sdk-extensions/incubator/build.gradle.kts

@@ -23,13 +23,15 @@ dependencies {
 
   // io.opentelemetry.sdk.extension.incubator.metric.viewconfig
   implementation(project(":sdk-extensions:autoconfigure-spi"))
-  implementation("org.snakeyaml:snakeyaml-engine")
+  compileOnly("org.snakeyaml:snakeyaml-engine")
 
   // io.opentelemetry.sdk.extension.incubator.fileconfig
   api(project(":api:incubator"))
-  implementation("com.fasterxml.jackson.core:jackson-databind")
+  compileOnly("com.fasterxml.jackson.core:jackson-databind")
   api("com.fasterxml.jackson.core:jackson-annotations")
-  implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml")
+
+  testImplementation("org.snakeyaml:snakeyaml-engine")
+  testImplementation("com.fasterxml.jackson.core:jackson-databind")
 
   testImplementation(project(":sdk:testing"))
   testImplementation(project(":sdk-extensions:autoconfigure"))