Skip to content

prom exporter: exclude shaded protobuf #7355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 2 commits into from
Jun 5, 2025
Merged

prom exporter: exclude shaded protobuf #7355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31d8d6e
exclude shaded protobuf
zeitlinger May 19, 2025
c60fbe1
Runtime only depends on io.prometheus:prometheus-metrics-exposition-t…
jack-berg Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions dependencyManagement/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ val jmhVersion = "1.37"
val mockitoVersion = "4.11.0"
val slf4jVersion = "2.0.17"
val opencensusVersion = "0.31.1"
val prometheusClientVersion = "0.16.0"
val prometheusServerVersion = "1.3.7"
val armeriaVersion = "1.32.5"
val junitVersion = "5.12.2"
Expand Down Expand Up @@ -65,12 +64,8 @@ val DEPENDENCIES = listOf(
"org.mockito:mockito-junit-jupiter:${mockitoVersion}",
"org.slf4j:slf4j-simple:${slf4jVersion}",
"org.slf4j:jul-to-slf4j:${slf4jVersion}",
"io.prometheus:prometheus-metrics-shaded-protobuf:1.3.1",
"io.prometheus:prometheus-metrics-exporter-httpserver:${prometheusServerVersion}",
"io.prometheus:prometheus-metrics-exposition-formats:${prometheusServerVersion}",
"io.prometheus:simpleclient:${prometheusClientVersion}",
"io.prometheus:simpleclient_common:${prometheusClientVersion}",
"io.prometheus:simpleclient_httpserver:${prometheusClientVersion}",
"io.prometheus:prometheus-metrics-exposition-formats-no-protobuf:${prometheusServerVersion}",
"javax.annotation:javax.annotation-api:1.3.2",
"com.github.stefanbirkner:system-rules:1.19.0",
"com.google.api.grpc:proto-google-common-protos:2.57.0",
Expand Down
7 changes: 4 additions & 3 deletions exporters/prometheus/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,17 @@ dependencies {
compileOnly(project(":api:incubator"))
implementation(project(":exporters:common"))
implementation(project(":sdk-extensions:autoconfigure-spi"))
implementation("io.prometheus:prometheus-metrics-exporter-httpserver")
implementation("io.prometheus:prometheus-metrics-exporter-httpserver") {
exclude(group = "io.prometheus", module = "prometheus-metrics-exposition-formats")
}
implementation("io.prometheus:prometheus-metrics-exposition-formats-no-protobuf")
Copy link
Copy Markdown
Member

@jack-berg jack-berg Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get away with io.prometheus:prometheus-metrics-exposition-textformats, and adding io.prometheus:prometheus-metrics-exposition-formats-no-protobuf as a testImplementation dependency. Pushing a commit to do this so we can get this in for tomorrow's release!


compileOnly("com.google.auto.value:auto-value-annotations")

annotationProcessor("com.google.auto.value:auto-value")

testImplementation(project(":sdk:testing"))
testImplementation("io.opentelemetry.proto:opentelemetry-proto")
testImplementation("io.prometheus:prometheus-metrics-shaded-protobuf")
testImplementation("io.prometheus:prometheus-metrics-exposition-formats")
testImplementation("com.sun.net.httpserver:http")
testImplementation("com.google.guava:guava")
testImplementation("com.linecorp.armeria:armeria")
Expand Down
Loading