Skip to content

sdk-extensions: remove 'Visible for test' comment#7381

Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom
kevinburkesegment:update-doc
Jun 3, 2025
Merged

sdk-extensions: remove 'Visible for test' comment#7381
jack-berg merged 1 commit intoopen-telemetry:mainfrom
kevinburkesegment:update-doc

Conversation

@kevinburkesegment
Copy link
Copy Markdown
Contributor

The function under the comment is invoked from other public classes, and should be indicated as a public function.

The function under the comment is invoked from other public classes,
and should be indicated as a public function.
@kevinburkesegment kevinburkesegment requested a review from a team as a code owner June 3, 2025 04:32
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (90e030f) to head (893cf28).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7381   +/-   ##
=========================================
  Coverage     89.83%   89.83%           
  Complexity     6895     6895           
=========================================
  Files           786      786           
  Lines         20793    20793           
  Branches       2026     2026           
=========================================
  Hits          18679    18679           
  Misses         1469     1469           
  Partials        645      645           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function under the comment is invoked from other public classes, and should be indicated as a public function.

Yes, definitely not used exclusively in tests, but is still package private rather than public.

Thanks!

@jack-berg jack-berg merged commit f94b056 into open-telemetry:main Jun 3, 2025
28 checks passed
@kevinburkesegment kevinburkesegment deleted the update-doc branch June 7, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants