sdk-extensions: remove 'Visible for test' comment#7381
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Jun 3, 2025
Merged
sdk-extensions: remove 'Visible for test' comment#7381jack-berg merged 1 commit intoopen-telemetry:mainfrom
jack-berg merged 1 commit intoopen-telemetry:mainfrom
Conversation
The function under the comment is invoked from other public classes, and should be indicated as a public function.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7381 +/- ##
=========================================
Coverage 89.83% 89.83%
Complexity 6895 6895
=========================================
Files 786 786
Lines 20793 20793
Branches 2026 2026
=========================================
Hits 18679 18679
Misses 1469 1469
Partials 645 645 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
approved these changes
Jun 3, 2025
Member
jack-berg
left a comment
There was a problem hiding this comment.
The function under the comment is invoked from other public classes, and should be indicated as a public function.
Yes, definitely not used exclusively in tests, but is still package private rather than public.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function under the comment is invoked from other public classes, and should be indicated as a public function.