Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,16 @@ public interface LogRecordBuilder {
/**
* Set the epoch {@code timestamp}, using the timestamp and unit.
*
* <p>The {@code timestamp} is the time at which the log record occurred. If unset, it will be set
* to the current time when {@link #emit()} is called.
* <p>Note: If the event timestamp is unset, it will NOT be automatically populated when
* {@link #emit()} is called. Only the observed timestamp receives a default value.
Comment thread
ruturajjadhav07 marked this conversation as resolved.
Outdated
*/
LogRecordBuilder setTimestamp(long timestamp, TimeUnit unit);

/**
* Set the epoch {@code timestamp}, using the instant.
*
* <p>The {@code timestamp} is the time at which the log record occurred. If unset, it will be set
* to the current time when {@link #emit()} is called.
* <p>Note: If the event timestamp is unset, it will NOT be automatically populated when
* {@link #emit()} is called. Only the observed timestamp receives a default value.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the note change here as well

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the note change here as well

Updated as suggested. Thank you!

*/
LogRecordBuilder setTimestamp(Instant instant);

Expand Down
Loading