Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8180 +/- ##
============================================
+ Coverage 90.29% 90.30% +0.01%
+ Complexity 7652 7643 -9
============================================
Files 843 842 -1
Lines 23066 23099 +33
Branches 2310 2325 +15
============================================
+ Hits 20827 20860 +33
+ Misses 1520 1519 -1
- Partials 719 720 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…y-java into series-start-time
dashpole
reviewed
Mar 16, 2026
Contributor
dashpole
left a comment
There was a problem hiding this comment.
this looks correct to me
jaydeluca
approved these changes
Mar 16, 2026
…ator epoch - Test that when a cumulative async series stops reporting for a collection cycle and then reappears, its start time is anchored to the collection immediately preceding its reappearance (not instrument creation time). - Add comment to DropAggregator.HANDLE explaining why creationEpochNanos=0 is safe (the handle never produces data points). Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Member
|
looks good - created jack-berg#23 for some small fixes |
Review follow-ups: DropAggregator comment + cumulative async reappearance test
Member
Author
|
Thanks @zeitlinger! Merged. |
zeitlinger
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts timeseries start time behavior to match the spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#start-timestamps
This is a prerequisite to finishing / closing instruments, a long time feature request.
Currently:
With this PR:
To accomplish this, I needed to:
cc @atoulme, @dashpole