Skip to content

Fix gradle change detection for config tasks #8181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 1 commit into from
Mar 12, 2026
Merged

Fix gradle change detection for config tasks #8181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions sdk-extensions/incubator/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,20 @@ val buildDirectory = layout.buildDirectory.asFile.get()

val downloadConfigurationSchema by tasks.registering(Download::class) {
src(configurationRepoZip)
dest("$buildDirectory/configuration/opentelemetry-configuration.zip")
// The version is encoded in the filename so that a configurationTag change results in a new
// path that doesn't yet exist, triggering a fresh download. On subsequent builds with the same
// tag the file already exists and overwrite(false) skips the network request. Note: the
// de.undercouch Download task always reports itself as not up-to-date, so overwrite(false) is
// the intended mechanism for avoiding redundant downloads.
//
// The zip is stored in tmp/ so it is outside the Sync task's output directory (configuration/).
dest("$buildDirectory/tmp/opentelemetry-configuration-v$configurationTag.zip")
overwrite(false)
}

val unzipConfigurationSchema by tasks.registering(Copy::class) {
val unzipConfigurationSchema by tasks.registering(Sync::class) {
// Sync (not Copy) removes stale files from the destination when the source changes, ensuring
// files deleted or renamed between schema versions don't linger in the build dir.
dependsOn(downloadConfigurationSchema)

from(zipTree(downloadConfigurationSchema.get().dest))
Expand All @@ -78,6 +87,7 @@ val unzipConfigurationSchema by tasks.registering(Copy::class) {
path = pathParts.subList(1, pathParts.size).joinToString("/")
})
into("$buildDirectory/configuration/")
includeEmptyDirs = false
}

jsonSchema2Pojo {
Expand Down
Loading