diff --git a/sdk-extensions/jaeger-remote-sampler/src/testGrpcNetty/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSamplerGrpcNettyTest.java b/sdk-extensions/jaeger-remote-sampler/src/testGrpcNetty/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSamplerGrpcNettyTest.java index af29d51281a..85297fa4afb 100644 --- a/sdk-extensions/jaeger-remote-sampler/src/testGrpcNetty/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSamplerGrpcNettyTest.java +++ b/sdk-extensions/jaeger-remote-sampler/src/testGrpcNetty/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSamplerGrpcNettyTest.java @@ -18,6 +18,7 @@ import io.grpc.ManagedChannel; import io.grpc.ManagedChannelBuilder; import io.opentelemetry.exporter.sender.grpc.managedchannel.internal.UpstreamGrpcSender; +import io.opentelemetry.internal.testing.CleanupExtension; import io.opentelemetry.internal.testing.slf4j.SuppressLogger; import io.opentelemetry.sdk.common.export.GrpcStatusCode; import io.opentelemetry.sdk.extension.trace.jaeger.proto.api_v2.Sampling; @@ -55,6 +56,8 @@ private static void addGrpcError(GrpcStatusCode code, @Nullable String message) grpcErrors.add(new ArmeriaStatusException(code.getValue(), message)); } + @RegisterExtension CleanupExtension cleanup = new CleanupExtension(); + @RegisterExtension LogCapturer logs = LogCapturer.create().captureForType(JaegerRemoteSampler.class, Level.TRACE); @@ -106,8 +109,11 @@ public void before() { responses.clear(); } - private static ManagedChannel managedChannel() { - return ManagedChannelBuilder.forTarget(server.httpUri().getAuthority()).usePlaintext().build(); + private ManagedChannel managedChannel() { + ManagedChannel channel = + ManagedChannelBuilder.forTarget(server.httpUri().getAuthority()).usePlaintext().build(); + cleanup.addCloseable(channel::shutdownNow); + return channel; } @Test @@ -148,9 +154,11 @@ void description() { @Test void initialSampler() { + ManagedChannel channel = ManagedChannelBuilder.forTarget("example.com").build(); + cleanup.addCloseable(channel::shutdownNow); try (JaegerRemoteSampler sampler = JaegerRemoteSampler.builder() - .setChannel(ManagedChannelBuilder.forTarget("example.com").build()) + .setChannel(channel) .setServiceName(SERVICE_NAME) .setInitialSampler(Sampler.alwaysOn()) .build()) {