Skip to content

Cleanup managed channel instances in jaeger remote sampler tests #8183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 1 commit into from
Mar 12, 2026
Merged

Cleanup managed channel instances in jaeger remote sampler tests #8183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSamplerGrpcNettyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import io.grpc.ManagedChannel;
import io.grpc.ManagedChannelBuilder;
import io.opentelemetry.exporter.sender.grpc.managedchannel.internal.UpstreamGrpcSender;
import io.opentelemetry.internal.testing.CleanupExtension;
import io.opentelemetry.internal.testing.slf4j.SuppressLogger;
import io.opentelemetry.sdk.common.export.GrpcStatusCode;
import io.opentelemetry.sdk.extension.trace.jaeger.proto.api_v2.Sampling;
Expand Down Expand Up @@ -55,6 +56,8 @@ private static void addGrpcError(GrpcStatusCode code, @Nullable String message)
grpcErrors.add(new ArmeriaStatusException(code.getValue(), message));
}

@RegisterExtension CleanupExtension cleanup = new CleanupExtension();

@RegisterExtension
LogCapturer logs = LogCapturer.create().captureForType(JaegerRemoteSampler.class, Level.TRACE);

Expand Down Expand Up @@ -106,8 +109,11 @@ public void before() {
responses.clear();
}

private static ManagedChannel managedChannel() {
return ManagedChannelBuilder.forTarget(server.httpUri().getAuthority()).usePlaintext().build();
private ManagedChannel managedChannel() {
ManagedChannel channel =
ManagedChannelBuilder.forTarget(server.httpUri().getAuthority()).usePlaintext().build();
cleanup.addCloseable(channel::shutdownNow);
return channel;
}

@Test
Expand Down Expand Up @@ -148,9 +154,11 @@ void description() {

@Test
void initialSampler() {
ManagedChannel channel = ManagedChannelBuilder.forTarget("example.com").build();
cleanup.addCloseable(channel::shutdownNow);
try (JaegerRemoteSampler sampler =
JaegerRemoteSampler.builder()
.setChannel(ManagedChannelBuilder.forTarget("example.com").build())
.setChannel(channel)
.setServiceName(SERVICE_NAME)
.setInitialSampler(Sampler.alwaysOn())
.build()) {
Expand Down
Loading