Skip to content

Enforce IncludedExcludeModel .included and .excluded are not empty#8266

Merged
jack-berg merged 3 commits into
open-telemetry:mainfrom
jack-berg:include-exclude-factory
Apr 10, 2026
Merged

Enforce IncludedExcludeModel .included and .excluded are not empty#8266
jack-berg merged 3 commits into
open-telemetry:mainfrom
jack-berg:include-exclude-factory

Conversation

@jack-berg
Copy link
Copy Markdown
Member

@jack-berg jack-berg requested a review from a team as a code owner April 8, 2026 16:25
import java.util.List;
import java.util.function.Predicate;

final class IncludeExcludeFactory implements Factory<IncludeExcludeModel, Predicate<String>> {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since IncludeExcludeFactory is a recurring concept in the config schema, create a dedicated factory which consistently enforces the constraints

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.28%. Comparing base (ec002c3) to head (d1aa80b).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ometheus/internal/PrometheusComponentProvider.java 33.33% 2 Missing and 2 partials ⚠️
.../fileconfig/ComposableRuleBasedSamplerFactory.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8266      +/-   ##
============================================
- Coverage     90.29%   90.28%   -0.02%     
- Complexity     7656     7667      +11     
============================================
  Files           844      845       +1     
  Lines         23071    23088      +17     
  Branches       2311     2318       +7     
============================================
+ Hits          20832    20845      +13     
- Misses         1521     1523       +2     
- Partials        718      720       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@zeitlinger zeitlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jack-berg jack-berg merged commit 2e385f8 into open-telemetry:main Apr 10, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants