Add hasValueSatisfying to LongPointAssert and DoublePointAssert#8328
Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom Apr 27, 2026
Merged
Add hasValueSatisfying to LongPointAssert and DoublePointAssert#8328jack-berg merged 2 commits intoopen-telemetry:mainfrom
jack-berg merged 2 commits intoopen-telemetry:mainfrom
Conversation
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8328 +/- ##
============================================
- Coverage 90.27% 90.27% -0.01%
- Complexity 7693 7694 +1
============================================
Files 850 850
Lines 23207 23213 +6
Branches 2356 2356
============================================
+ Hits 20951 20956 +5
Misses 1530 1530
- Partials 726 727 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
laurit
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would help simplify a few metric assertions in the instrumentation repo and feels like a pretty natural addition.