Skip to content

Add hasValueSatisfying to LongPointAssert and DoublePointAssert#8328

Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom
trask:has-value-satisfying
Apr 27, 2026
Merged

Add hasValueSatisfying to LongPointAssert and DoublePointAssert#8328
jack-berg merged 2 commits intoopen-telemetry:mainfrom
trask:has-value-satisfying

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Apr 24, 2026

This would help simplify a few metric assertions in the instrumentation repo and feels like a pretty natural addition.

@otelbot otelbot Bot added the api-change Changes to public API surface area label Apr 24, 2026
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Apr 24, 2026

⚠️ API changes detected — additional maintainer review required

@jack-berg @jkwatson

This PR modifies the public API surface area of the following module(s):

  • opentelemetry-sdk-testing

Please review the changes in docs/apidiffs/current_vs_latest/ carefully before approving.

Copy link
Copy Markdown
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.27%. Comparing base (fdb8194) to head (8e52b1d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8328      +/-   ##
============================================
- Coverage     90.27%   90.27%   -0.01%     
- Complexity     7693     7694       +1     
============================================
  Files           850      850              
  Lines         23207    23213       +6     
  Branches       2356     2356              
============================================
+ Hits          20951    20956       +5     
  Misses         1530     1530              
- Partials        726      727       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trask trask marked this pull request as ready for review April 24, 2026 16:06
@trask trask requested a review from a team as a code owner April 24, 2026 16:06
@jack-berg jack-berg merged commit f674cdd into open-telemetry:main Apr 27, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to public API surface area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants