Add containsPointsSatisfying to metric data asserts#8329
Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom Apr 28, 2026
Merged
Add containsPointsSatisfying to metric data asserts#8329jack-berg merged 2 commits intoopen-telemetry:mainfrom
jack-berg merged 2 commits intoopen-telemetry:mainfrom
Conversation
Parallels hasAttributesSatisfying's subset semantics: each listed
assertion must be satisfied by at least one point, extras are allowed,
and a single point may satisfy multiple assertions.
The existing hasPointsSatisfying requires the caller to enumerate every
point (via satisfiesExactlyInAnyOrder), which is awkward when point
cardinality varies across runs (e.g. JVM runtime telemetry snapshots).
Today callers drop down to raw AssertJ:
sum.satisfies(s -> assertThat(s.getPoints())
.anyMatch(p -> p.getAttributes().equals(...))
.anyMatch(p -> p.getAttributes().equals(...)))
which is noisy and loses the typed PointAssert. containsPointsSatisfying
keeps the typed chain.
Added to: DoubleGaugeAssert, DoubleSumAssert, LongGaugeAssert,
LongSumAssert, HistogramAssert, ExponentialHistogramAssert,
SummaryAssert.
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8329 +/- ##
============================================
+ Coverage 90.27% 90.28% +0.01%
- Complexity 7695 7722 +27
============================================
Files 850 850
Lines 23213 23262 +49
Branches 2356 2363 +7
============================================
+ Hits 20955 21003 +48
Misses 1531 1531
- Partials 727 728 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
approved these changes
Apr 24, 2026
jkwatson
approved these changes
Apr 24, 2026
Member
|
Will merge when conflicts are resolved @trask |
…isfying # Conflicts: # CHANGELOG.md # docs/apidiffs/current_vs_latest/opentelemetry-sdk-testing.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, we can't follow
hasAttributesSatisfying/hasAttributesSatisfyingExactlypattern, sincehasPointsSatisfyingis doing the "Exactly" behavior already.containsPointsSatisfyingis the best name I could come up with to differentiate withhasPointsSatisfying.Demonstration of this new method at open-telemetry/opentelemetry-java-instrumentation#18263