Don't allocate for parentContext on span start for the common case#8332
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8332 +/- ##
============================================
- Coverage 90.27% 90.25% -0.03%
Complexity 7693 7693
============================================
Files 850 850
Lines 23207 23210 +3
Branches 2356 2357 +1
============================================
- Hits 20951 20948 -3
- Misses 1530 1537 +7
+ Partials 726 725 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
psx95
approved these changes
Apr 28, 2026
jkwatson
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8263 fixed a bug where parentContext wasn't properly being passed to shouldSample for the root case. Its correct, but the code calls
parentContext.with(RANDOM_TRACE_ID_PRIMORDIAL_SPAN), which allocates to store the RANDOM_TRACE_ID_PRIMORDIAL_SPAN in context every time a root span is started.But its common (I would say the majority of the time) for parent context to be
Context.root()in this case. Therefore, we can avoid allocating by keeping a constantContext.root().with(RANDOM_TRACE_ID_PRIMORDIAL_SPAN)and always returning that whenparentContext == Context.root().Followup to #8263 (comment)
cc @PeterF778