fix: LoggingSpanExporter and LoggingMetricExporter flush() always returns success#8361
Open
ADITYA-CODE-SOURCE wants to merge 3 commits intoopen-telemetry:mainfrom
Open
fix: LoggingSpanExporter and LoggingMetricExporter flush() always returns success#8361ADITYA-CODE-SOURCE wants to merge 3 commits intoopen-telemetry:mainfrom
ADITYA-CODE-SOURCE wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
…urns success LoggingSpanExporter.flush() and LoggingMetricExporter.flush() unconditionally return success even if underlying handlers fail. This masks errors from the caller. Fixes open-telemetry#8360
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8361 +/- ##
============================================
+ Coverage 90.82% 90.83% +0.01%
Complexity 7927 7927
============================================
Files 895 895
Lines 23872 23870 -2
Branches 2378 2376 -2
============================================
+ Hits 21681 21683 +2
+ Misses 1446 1442 -4
Partials 745 745 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where LoggingSpanExporter.flush() and LoggingMetricExporter.flush() unconditionally returned success, even if underlying logger handlers failed during flushing. This masked errors from the caller.
Changes
Fixes #8360