Skip to content

fix: LoggingSpanExporter.flush() should preserve flush failures #8361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 7 commits into from
May 8, 2026
+67 −21
Merged

fix: LoggingSpanExporter.flush() should preserve flush failures #8361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7454852
fix: LoggingSpanExporter and LoggingMetricExporter flush() always ret…
ADITYA-CODE-SOURCE May 2, 2026
be535cb
fix: explicitly return Success when flush completes without error
ADITYA-CODE-SOURCE May 2, 2026
7195477
test: add flush failure coverage for LoggingSpanExporter and LoggingM…
ADITYA-CODE-SOURCE May 2, 2026
a8a5e54
fix: narrow flush fix to span exporter
ADITYA-CODE-SOURCE May 7, 2026
db11577
fix: disable config cache for graal incubating test
ADITYA-CODE-SOURCE May 7, 2026
49a8703
test: isolate logging exporter flush handlers
ADITYA-CODE-SOURCE May 7, 2026
0e034ab
chore: restore graal incubating formatting
ADITYA-CODE-SOURCE May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exporters/logging/src/main/java/io/opentelemetry/exporter/logging/LoggingSpanExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public CompletableResultCode flush() {
try {
handler.flush();
} catch (Throwable t) {
resultCode.fail();
Comment thread
ADITYA-CODE-SOURCE marked this conversation as resolved.
return resultCode.fail();
}
}
return resultCode.succeed();
Expand Down
43 changes: 33 additions & 10 deletions ...rs/logging/src/test/java/io/opentelemetry/exporter/logging/LoggingMetricExporterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,16 +89,39 @@ void export() {
@Test
void flush() {
AtomicBoolean flushed = new AtomicBoolean(false);
Logger.getLogger(LoggingMetricExporter.class.getName())
.addHandler(
new StreamHandler(new PrintStream(new ByteArrayOutputStream()), new SimpleFormatter()) {
@Override
public synchronized void flush() {
flushed.set(true);
}
});
exporter.flush();
assertThat(flushed.get()).isTrue();
Logger logger = Logger.getLogger(LoggingMetricExporter.class.getName());
StreamHandler handler =
new StreamHandler(new PrintStream(new ByteArrayOutputStream()), new SimpleFormatter()) {
@Override
public synchronized void flush() {
flushed.set(true);
}
};
logger.addHandler(handler);
try {
exporter.flush();
assertThat(flushed.get()).isTrue();
} finally {
logger.removeHandler(handler);
}
}

@Test
void flushFailure() {
Logger logger = Logger.getLogger(LoggingMetricExporter.class.getName());
StreamHandler failingHandler =
new StreamHandler(new PrintStream(new ByteArrayOutputStream()), new SimpleFormatter()) {
@Override
public synchronized void flush() {
throw new RuntimeException("Flush failed");
}
};
logger.addHandler(failingHandler);
try {
assertThat(exporter.flush().isSuccess()).isFalse();
} finally {
logger.removeHandler(failingHandler);
}
}

@Test
Expand Down
43 changes: 33 additions & 10 deletions ...ters/logging/src/test/java/io/opentelemetry/exporter/logging/LoggingSpanExporterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,16 +127,39 @@ void export() {
@Test
void flush() {
AtomicBoolean flushed = new AtomicBoolean(false);
Logger.getLogger(LoggingSpanExporter.class.getName())
.addHandler(
new StreamHandler(new PrintStream(new ByteArrayOutputStream()), new SimpleFormatter()) {
@Override
public synchronized void flush() {
flushed.set(true);
}
});
exporter.flush();
assertThat(flushed.get()).isTrue();
Logger logger = Logger.getLogger(LoggingSpanExporter.class.getName());
StreamHandler handler =
new StreamHandler(new PrintStream(new ByteArrayOutputStream()), new SimpleFormatter()) {
@Override
public synchronized void flush() {
flushed.set(true);
}
};
logger.addHandler(handler);
try {
exporter.flush();
assertThat(flushed.get()).isTrue();
} finally {
logger.removeHandler(handler);
}
}

@Test
void flushFailure() {
Logger logger = Logger.getLogger(LoggingSpanExporter.class.getName());
StreamHandler failingHandler =
new StreamHandler(new PrintStream(new ByteArrayOutputStream()), new SimpleFormatter()) {
@Override
public synchronized void flush() {
throw new RuntimeException("Flush failed");
}
};
logger.addHandler(failingHandler);
try {
assertThat(exporter.flush().isSuccess()).isFalse();
} finally {
logger.removeHandler(failingHandler);
}
}

@Test
Expand Down
Loading