Limit exemplar label characters to conform to Prometheus limits#8362
Open
anuq wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Limit exemplar label characters to conform to Prometheus limits#8362anuq wants to merge 2 commits intoopen-telemetry:mainfrom
anuq wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
6f05ab7 to
a0627db
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8362 +/- ##
============================================
+ Coverage 90.82% 90.84% +0.02%
- Complexity 7927 7932 +5
============================================
Files 895 895
Lines 23872 23886 +14
Branches 2378 2381 +3
============================================
+ Hits 21681 21700 +19
+ Misses 1446 1442 -4
+ Partials 745 744 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6770
Limits exemplar label characters to Prometheus's 128 UTF-8 character maximum. When labels exceed this limit, filtered attributes are dropped while preserving trace_id and span_id for correlation.
Changes