Skip to content

Merge colliding Prometheus label values#8364

Open
ADITYA-CODE-SOURCE wants to merge 1 commit intoopen-telemetry:mainfrom
ADITYA-CODE-SOURCE:issue-8236-prometheus-label-collisions
Open

Merge colliding Prometheus label values#8364
ADITYA-CODE-SOURCE wants to merge 1 commit intoopen-telemetry:mainfrom
ADITYA-CODE-SOURCE:issue-8236-prometheus-label-collisions

Conversation

@ADITYA-CODE-SOURCE
Copy link
Copy Markdown

Summary

  • merge colliding normalized attribute labels by joining values with ';' in original-key order
  • preserve existing precedence between metric, resource, and synthetic labels while fixing collision handling
  • add regression tests for both metric attribute and allowed resource attribute normalization conflicts

Fixes #8236

Preserve Prometheus compatibility when normalized attribute names collide
by joining the values in original-key order instead of letting later
entries overwrite earlier ones. Add regression tests for metric and
resource attribute collisions.

Fixes open-telemetry#8236
@ADITYA-CODE-SOURCE ADITYA-CODE-SOURCE requested a review from a team as a code owner May 3, 2026 16:44
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.83%. Comparing base (1b207c6) to head (8f2b4ab).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8364      +/-   ##
============================================
+ Coverage     90.82%   90.83%   +0.01%     
- Complexity     7927     7933       +6     
============================================
  Files           895      895              
  Lines         23872    23899      +27     
  Branches       2378     2378              
============================================
+ Hits          21681    21708      +27     
  Misses         1446     1446              
  Partials        745      745              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prometheus attribute conversion should merge values when collisions occur

1 participant