OpAmp: added TLS configuration support for insecure endpoints#4921
Open
Horiodino wants to merge 2 commits into
Open
OpAmp: added TLS configuration support for insecure endpoints#4921Horiodino wants to merge 2 commits into
Horiodino wants to merge 2 commits into
Conversation
Signed-off-by: Praful <holiodin@gmail.com>
Signed-off-by: Praful <holiodin@gmail.com>
6f09319 to
fc86640
Compare
swiatekm
approved these changes
Apr 2, 2026
Contributor
swiatekm
left a comment
There was a problem hiding this comment.
LGTM, @jaronoff97 can you have a look as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds TLS configuration support to the OpAMP Bridge, including options for disabling TLS (
tls.insecure) and skipping certificate verification (tls.insecure_skip_verify).Introduced a new
OpAMPBridgeTLSConfigstruct in the API.Updated the agent to handle TLS behavior:
wss/https) to (ws/http) whentls.insecure=true.InsecureSkipVerifywhentls.insecure_skip_verify=true.Added validation to prevent both options being enabled simultaneously.
Link to tracking Issue(s):
Testing:
Added unit tests for agent TLS behavior covering:
Updated e2e tests to include TLS insecure configuration and verify no runtime errors (including handshake issues).
Documentation: