target allocator: add configurable mTLS option for TA crds#4971
target allocator: add configurable mTLS option for TA crds#4971Horiodino wants to merge 4 commits into
Conversation
|
You don't need to add this to v1alpha1, we're going to be removing it shortly. |
E2E Test Results2 files 6 suites 6m 13s ⏱️ Results for commit 3ea4361. ♻️ This comment has been updated with latest results. |
|
cc @swiatekm |
swiatekm
left a comment
There was a problem hiding this comment.
You also need to update the documentation in cmd/otel-allocator to reflect this change.
3f8f86f to
7140516
Compare
swiatekm
left a comment
There was a problem hiding this comment.
I think we need to think about this more carefully. This feature should also work for the TargetAllocator CRD, which I don't believe is the case right now. The way this is typically implemented is that there's an attribute on TargetAllocator.spec, and setting it on the Collector forwards it there in https://github.com/open-telemetry/opentelemetry-operator/blob/main/internal/manifests/collector/targetallocator.go.
In this case, we also need to do some stuff in the Collector itself, and the right check for this is by looking at params.TargetAllocator, the same way this is done for config manipulation. The reverse of what this PR does, where it checks the collector CR while generating the TargetAllocator manifests.
Does that make sense, @Horiodino ?
Signed-off-by: Praful Khanduri <holiodin@gmail.com>
Signed-off-by: Praful Khanduri <holiodin@gmail.com>
Signed-off-by: Praful Khanduri <holiodin@gmail.com>
…hortly Signed-off-by: Praful Khanduri <holiodin@gmail.com>
Description:
Added
mtls.enabledoption to Target Allocator (in bothOpenTelemetryCollectorandTargetAllocator). This replaces theoperator.targetallocator.mtlsfeature gate.Link to tracking Issue(s):
Testing:
Documentation: