Skip to content

target allocator: add configurable mTLS option for TA crds#4971

Open
Horiodino wants to merge 4 commits into
open-telemetry:mainfrom
Horiodino:mtls
Open

target allocator: add configurable mTLS option for TA crds#4971
Horiodino wants to merge 4 commits into
open-telemetry:mainfrom
Horiodino:mtls

Conversation

@Horiodino
Copy link
Copy Markdown
Member

Description:
Added mtls.enabled option to Target Allocator (in both OpenTelemetryCollector and TargetAllocator ). This replaces the operator.targetallocator.mtls feature gate.

Link to tracking Issue(s):

Testing:

  • Updated unit tests.
  • Updated e2e tests.

Documentation:

  • Updated API docs and added changelog.

@Horiodino Horiodino requested a review from a team as a code owner April 17, 2026 07:04
@swiatekm
Copy link
Copy Markdown
Contributor

You don't need to add this to v1alpha1, we're going to be removing it shortly.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

E2E Test Results

2 files  6 suites   6m 13s ⏱️
3 tests 3 ✅ 0 💤 0 ❌
6 runs  6 ✅ 0 💤 0 ❌

Results for commit 3ea4361.

♻️ This comment has been updated with latest results.

@Horiodino
Copy link
Copy Markdown
Member Author

cc @swiatekm

Copy link
Copy Markdown
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the documentation in cmd/otel-allocator to reflect this change.

Comment thread apis/v1beta1/opentelemetrycollector_types.go
Comment thread .github/workflows/e2e-reusable.yaml
@Horiodino Horiodino force-pushed the mtls branch 3 times, most recently from 3f8f86f to 7140516 Compare April 29, 2026 10:10
Copy link
Copy Markdown
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to think about this more carefully. This feature should also work for the TargetAllocator CRD, which I don't believe is the case right now. The way this is typically implemented is that there's an attribute on TargetAllocator.spec, and setting it on the Collector forwards it there in https://github.com/open-telemetry/opentelemetry-operator/blob/main/internal/manifests/collector/targetallocator.go.

In this case, we also need to do some stuff in the Collector itself, and the right check for this is by looking at params.TargetAllocator, the same way this is done for config manipulation. The reverse of what this PR does, where it checks the collector CR while generating the TargetAllocator manifests.

Does that make sense, @Horiodino ?

Comment thread internal/controllers/opentelemetrycollector_controller.go Outdated
Horiodino added 4 commits May 11, 2026 12:48
Signed-off-by: Praful Khanduri <holiodin@gmail.com>
Signed-off-by: Praful Khanduri <holiodin@gmail.com>
Signed-off-by: Praful Khanduri <holiodin@gmail.com>
…hortly

Signed-off-by: Praful Khanduri <holiodin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a config option for enabling target allocator mTLS

2 participants