WIP: fix(target-allocator): decode prom-operator types with json:",inline" embedded structs#4992
Draft
ozzywalsh wants to merge 4 commits into
Draft
Conversation
… embedded structs The TA config deserializer uses mapstructure with TagName:"yaml", which cannot squash embedded structs tagged with json:",inline" (e.g. TLSConfig embedding SafeTLSConfig and TLSFilesConfig). This silently drops fields like CAFile and InsecureSkipVerify when deserializing ScrapeClass TLS configuration from the ConfigMap. Add a generic decode hook (MapToMonitoringV1) that round-trips all monitoring/v1 types through sigs.k8s.io/yaml, which internally converts YAML to JSON and uses json.Unmarshal — correctly handling json:",inline".
Contributor
E2E Test Results 34 files 253 suites 2h 25m 36s ⏱️ Results for commit 75e2a6f. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.