Skip to content

RFC: ClusterObservabilityPatch CR#5144

Open
frzifus wants to merge 1 commit into
open-telemetry:mainfrom
frzifus:rfc/cluster-observability-patch
Open

RFC: ClusterObservabilityPatch CR#5144
frzifus wants to merge 1 commit into
open-telemetry:mainfrom
frzifus:rfc/cluster-observability-patch

Conversation

@frzifus

@frzifus frzifus commented May 26, 2026

Copy link
Copy Markdown
Member

Summary

  • Proposes a new ClusterObservabilityPatch custom resource for applying targeted overrides to managed OpenTelemetryCollector and Instrumentation CRs
  • Follows the policy-attachment pattern (similar to Envoy Gateway's EnvoyPatchPolicy) — patches are separate resources applied atomically during reconciliation
  • Enables vendors to ship platform-specific integration patches (e.g., wiring telemetry into OpenShift's built-in observability stack)


Better readable version: https://github.com/frzifus/opentelemetry-operator/blob/rfc/cluster-observability-patch/docs/rfcs/cluster-observability-patch.md

Proposes a new ClusterObservabilityPatch custom resource that allows
users and vendors to apply targeted overrides to managed
OpenTelemetryCollector and Instrumentation CRs without modifying the
ClusterObservability CR itself.

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus frzifus requested a review from a team as a code owner May 26, 2026 13:30
@frzifus frzifus added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 26, 2026
@frzifus

frzifus commented May 26, 2026

Copy link
Copy Markdown
Member Author

cc @jinja2 @atoulme

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

 38 files  269 suites   2h 25m 35s ⏱️
114 tests 113 ✅ 1 💤 0 ❌
291 runs  289 ✅ 2 💤 0 ❌

Results for commit d0e92c5.

♻️ This comment has been updated with latest results.

@frzifus frzifus added the area:cluster-observability Issues for the ClusterObservability resource label May 26, 2026
@atoulme

atoulme commented May 27, 2026

Copy link
Copy Markdown
Contributor

Can 2 patches conflict with each other? Is there a precedence to them? Is there a notion of scope to a patch, such that it applies to a subset of the cluster (only one namespace for example)?

- Patches are applied atomically during reconciliation — no race condition between resource creation and
patching.
- Patches are validated at admission time where possible (target exists, patch structure is valid).
- Multiple `ClusterObservabilityPatch` resources can coexist with deterministic ordering via a priority field.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this on first read.

@swiatekm swiatekm requested review from a team June 13, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:cluster-observability Issues for the ClusterObservability resource Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants