comments

Author: JWinermaSplunk

instrumentation/opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/__init__.py

@@ -249,9 +249,7 @@ def record_factory(*args, **kwargs):
             )
             handler_level = kwargs.get(
                 "log_handler_level",
-                _get_log_level(environ[OTEL_PYTHON_LOG_HANDLER_LEVEL])
-                if OTEL_PYTHON_LOG_HANDLER_LEVEL in environ
-                else None,
+                _get_log_level(environ.get(OTEL_PYTHON_LOG_HANDLER_LEVEL)),
             )
             logger_provider = get_logger_provider()
             handler = _setup_logging_handler(

instrumentation/opentelemetry-instrumentation-logging/src/opentelemetry/instrumentation/logging/handler.py

@@ -36,7 +36,9 @@
 from opentelemetry.util.types import _ExtendedAttributes
 
 
-def _get_log_level(level_name: str) -> int:
+def _get_log_level(level_name: str | None) -> int | None:
+    if level_name is None:
+        return None
     result = logging.getLevelName(level_name.upper().strip())
     return result if isinstance(result, int) else logging.NOTSET
 

instrumentation/opentelemetry-instrumentation-logging/tests/test_handler.py

@@ -687,6 +687,9 @@ def test_setup_logging_handler_default_level_is_notset(self):
 
 
 class GetLogLevelTestCase(unittest.TestCase):
+    def test_get_log_level_none_returns_none(self):
+        self.assertIsNone(_get_log_level(None))
+
     def test_get_log_level_notset(self):
         self.assertEqual(_get_log_level("notset"), logging.NOTSET)