Skip to content

Commit 2c6fd20

Browse files
fix: declare opentelemetry-semantic-conventions for aio-pika, logging, pika and system-metrics (#4594)
* fix: declare opentelemetry-semantic-conventions for four instrumentations The aio-pika, logging, pika and system-metrics instrumentations import opentelemetry.semconv directly but only resolved it transitively through opentelemetry-instrumentation. Declare it explicitly in each pyproject.toml so the package metadata reflects the actual imports, following up on #4590. * Rename changelog fragment to PR number --------- Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
1 parent f569518 commit 2c6fd20

6 files changed

Lines changed: 13 additions & 0 deletions

File tree

.changelog/4594.fixed

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Declare `opentelemetry-semantic-conventions` as a direct dependency for the aio-pika, logging, pika and system-metrics instrumentations, since each imports `opentelemetry.semconv` directly.

instrumentation/opentelemetry-instrumentation-aio-pika/pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ classifiers = [
2727
dependencies = [
2828
"opentelemetry-api ~= 1.5",
2929
"opentelemetry-instrumentation == 0.63b0.dev",
30+
"opentelemetry-semantic-conventions == 0.63b0.dev",
3031
"wrapt >= 1.0.0, < 3.0.0",
3132
]
3233

instrumentation/opentelemetry-instrumentation-logging/pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ classifiers = [
2727
dependencies = [
2828
"opentelemetry-api ~= 1.12",
2929
"opentelemetry-instrumentation == 0.63b0.dev",
30+
"opentelemetry-semantic-conventions == 0.63b0.dev",
3031
]
3132

3233
[project.optional-dependencies]

instrumentation/opentelemetry-instrumentation-pika/pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ classifiers = [
2626
]
2727
dependencies = [
2828
"opentelemetry-instrumentation == 0.63b0.dev",
29+
"opentelemetry-semantic-conventions == 0.63b0.dev",
2930
"opentelemetry-api ~= 1.5",
3031
"packaging >= 20.0",
3132
"wrapt >= 1.0.0, < 3.0.0",

instrumentation/opentelemetry-instrumentation-system-metrics/pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ classifiers = [
2626
]
2727
dependencies = [
2828
"opentelemetry-instrumentation == 0.63b0.dev",
29+
"opentelemetry-semantic-conventions == 0.63b0.dev",
2930
"opentelemetry-api ~= 1.11",
3031
"psutil >= 5.9.0, < 8",
3132
]

uv.lock

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)